Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Picky about TZ dates... »

Picky about TZ dates...

php.internals

David Hill (php.net)

23 years ago
Hi all, It would seem that Tru64 is pickier about the TZ setting than the rest of the known universe. According to our local TZ expert (who can quote chapter and verse from the UNIX 98 standard) a TZ of GMT is not proper, and GMT0 is (again despite the fact that every other platform seems to have no problem with it) On all of the machines flavors I have to try, GMT0 works. This pickyiness causes 3 test "failures" for me. The affected tests in php5 are: ./ext/standard/tests/time/002.phpt: putenv ("TZ=GMT"); ./ext/standard/tests/time/idate.phpt:putenv ("TZ=GMT"); ./ext/standard/tests/time/mktime.phpt: 'GMT', Unless I hear of any negatives, I would like to change these to GMT0 so I can concentrate on the real bugs. Dave

Moriyoshi Koizumi

23 years ago
Choosy OS.. It seems like a valid fix for me. Moriyoshi "David Hill \(php.net\)" <ddhill@php.net> wrote:

(Marcus Börger)

23 years ago
At 19:56 24.03.2003, David Hill (php.net) wrote:
>Hi all, > It would seem that Tru64 is pickier about the TZ setting than the > rest of the known universe. According to our local TZ expert (who can > quote chapter and verse from the UNIX 98 standard) a TZ of GMT is not > proper, and GMT0 is (again despite the fact that every other platform > seems to have no problem with it) On all of the machines flavors I have > to try, GMT0 works. > >This pickyiness causes 3 test "failures" for me. > >The affected tests in php5 are: >../ext/standard/tests/time/002.phpt: putenv ("TZ=GMT"); >../ext/standard/tests/time/idate.phpt:putenv ("TZ=GMT"); >../ext/standard/tests/time/mktime.phpt: 'GMT', > >Unless I hear of any negatives, I would like to change these to GMT0 so I >can concentrate on the real bugs.
PASS for mdk 8.2. Here is the patch Index: ext/standard/tests/time/002.phpt =================================================================== RCS file: /repository/php4/ext/standard/tests/time/002.phpt,v retrieving revision 1.7 diff -u -r1.7 002.phpt --- ext/standard/tests/time/002.phpt 13 Mar 2003 18:51:39 -0000 1.7 +++ ext/standard/tests/time/002.phpt 24 Mar 2003 20:44:20 -0000 @@ -28,7 +28,7 @@ "2001-10-22 21:19:58+0213" ); - putenv ("TZ=GMT"); + putenv ("TZ=GMT0"); foreach ($dates as $date) { echo date ("Y-m-d H:i:s\n", strtotime ($date)); } Index: ext/standard/tests/time/idate.phpt =================================================================== RCS file: /repository/php4/ext/standard/tests/time/idate.phpt,v retrieving revision 1.2 diff -u -r1.2 idate.phpt --- ext/standard/tests/time/idate.phpt 17 Feb 2003 06:23:22 -0000 1.2 +++ ext/standard/tests/time/idate.phpt 24 Mar 2003 20:44:20 -0000 @@ -2,7 +2,7 @@ idate() function --FILE-- <?php -putenv ("TZ=GMT"); +putenv ("TZ=GMT0"); $tmp = "UYzymndjHGhgistwLBIW"; for($a = 0;$a < strlen($tmp); $a++){ Index: ext/standard/tests/time/mktime.phpt =================================================================== RCS file: /repository/php4/ext/standard/tests/time/mktime.phpt,v retrieving revision 1.2 diff -u -r1.2 mktime.phpt --- ext/standard/tests/time/mktime.phpt 9 Feb 2003 12:19:02 -0000 1.2 +++ ext/standard/tests/time/mktime.phpt 24 Mar 2003 20:44:20 -0000 @@ -3,7 +3,7 @@ --FILE-- <?php $timezones = array( - 'GMT', + 'GMT0', 'GST-1GDT' );

Dave Hill

23 years ago
I need to change the US/Eastern references as well - needs to be EST5 or EST-5. Dave ----- Original Message ----- From: "Marcus Börger" <marcus.boerger@t-online.de> To: "David Hill (php.net)" <ddhill@php.net> Cc: "Php-Qa" <php-qa@lists.php.net>; <internals@lists.php.net> Sent: Monday, March 24, 2003 2:49 PM Subject: Re: [PHP-QA] Picky about TZ dates...
> At 19:56 24.03.2003, David Hill (php.net) wrote: > >Hi all, > > It would seem that Tru64 is pickier about the TZ setting than
the
> > rest of the known universe. According to our local TZ expert (who
can
> > quote chapter and verse from the UNIX 98 standard) a TZ of GMT is
not
> > proper, and GMT0 is (again despite the fact that every other
platform
> > seems to have no problem with it) On all of the machines flavors
I have
> > to try, GMT0 works. > > > >This pickyiness causes 3 test "failures" for me. > > > >The affected tests in php5 are: > >../ext/standard/tests/time/002.phpt: putenv ("TZ=GMT"); > >../ext/standard/tests/time/idate.phpt:putenv ("TZ=GMT"); > >../ext/standard/tests/time/mktime.phpt: 'GMT', > > > >Unless I hear of any negatives, I would like to change these to
GMT0 so I
> >can concentrate on the real bugs. > > > PASS for mdk 8.2. > > Here is the patch > > Index: ext/standard/tests/time/002.phpt > =================================================================== > RCS file: /repository/php4/ext/standard/tests/time/002.phpt,v > retrieving revision 1.7 > diff -u -r1.7 002.phpt > --- ext/standard/tests/time/002.phpt 13 Mar 2003 18:51:39 -0000
1.7
> +++ ext/standard/tests/time/002.phpt 24 Mar 2003 20:44:20 -0000 > @@ -28,7 +28,7 @@ > "2001-10-22 21:19:58+0213" > ); > > - putenv ("TZ=GMT"); > + putenv ("TZ=GMT0"); > foreach ($dates as $date) { > echo date ("Y-m-d H:i:s\n", strtotime ($date)); > } > Index: ext/standard/tests/time/idate.phpt > =================================================================== > RCS file: /repository/php4/ext/standard/tests/time/idate.phpt,v > retrieving revision 1.2 > diff -u -r1.2 idate.phpt > --- ext/standard/tests/time/idate.phpt 17 Feb 2003 06:23:22 -0000
1.2
> +++ ext/standard/tests/time/idate.phpt 24 Mar 2003 20:44:20 -0000 > @@ -2,7 +2,7 @@ > idate() function > --FILE-- > <?php > -putenv ("TZ=GMT"); > +putenv ("TZ=GMT0"); > > $tmp = "UYzymndjHGhgistwLBIW"; > for($a = 0;$a < strlen($tmp); $a++){ > Index: ext/standard/tests/time/mktime.phpt > =================================================================== > RCS file: /repository/php4/ext/standard/tests/time/mktime.phpt,v > retrieving revision 1.2 > diff -u -r1.2 mktime.phpt > --- ext/standard/tests/time/mktime.phpt 9 Feb 2003 12:19:02 -0000
1.2