Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [VOTE] Importing namespaced functions »

[VOTE] Importing namespaced functions

php.internals

Igor Wiedler

13 years ago
Hello internals, About 3 weeks have passed since I announced the use_function RFC. A number of issues were raised, and I believe all of them have been resolved at this point. I would like to initiate the voting phase. RFC: https://wiki.php.net/rfc/use_function Patch: https://github.com/php/php-src/pull/388 * The vote is on the implementation, so please check the patch. * Since this is changing the language, it will need a 2/3 majority to be accepted. * The voting period ends in 2 weeks: on August 29th at 14.00 GMT. Cheers, Igor

Peter Cowburn

13 years ago
On 15 August 2013 15:08, Igor Wiedler <igor@wiedler.ch> wrote:
> Hello internals, > > About 3 weeks have passed since I announced the use_function RFC. A number > of issues were raised, and I believe all of them have been resolved at this > point. I would like to initiate the voting phase. > > RFC: https://wiki.php.net/rfc/use_function > Patch: https://github.com/php/php-src/pull/388 > > * The vote is on the implementation, so please check the patch. > * Since this is changing the language, it will need a 2/3 majority to be > accepted. > * The voting period ends in 2 weeks: on August 29th at 14.00 GMT. >
Don't forget to create a new [VOTE] thread (unless you already have, and my inbox is just being slow today).

Igor Wiedler

13 years ago
Hi Peter, This *is* the [VOTE] thread. Am I missing something? :) Regards, Igor On Aug 15, 2013, at 4:20 PM, Peter Cowburn <petercowburn@gmail.com> wrote:

Peter Cowburn

13 years ago
On 15 August 2013 15:23, Igor Wiedler <igor@wiedler.ch> wrote:
> Hi Peter, > > This *is* the [VOTE] thread. Am I missing something? :) >
The vote is announced on the mailing list in a separate thread by sending an email with the subject *[VOTE]*. It should reference the RFCs being voted on and if there are different options discussed, explain these options. It should also contain the URL of the page where the vote is taking place. - From https://wiki.php.net/rfc/voting

Peter Cowburn

13 years ago
On 15 August 2013 15:23, Igor Wiedler <igor@wiedler.ch> wrote:
> Hi Peter, > > This *is* the [VOTE] thread. Am I missing something? :) >
Stupid Gmail! :)

Pierre Joye

13 years ago
On Thu, Aug 15, 2013 at 4:23 PM, Igor Wiedler <igor@wiedler.ch> wrote:
> Hi Peter, > > This *is* the [VOTE] thread. Am I missing something? :)
Did you do a new mail or reply to this one? The sooner is the right way, did not see a vote thread (gmail or other clients)
-- Pierre @pierrejoye | http://www.libgd.org

Ferenc Kovacs

13 years ago
On Mon, Aug 19, 2013 at 7:35 AM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Thu, Aug 15, 2013 at 4:23 PM, Igor Wiedler <igor@wiedler.ch> wrote: > > Hi Peter, > > > > This *is* the [VOTE] thread. Am I missing something? :) > > Did you do a new mail or reply to this one? The sooner is the right > way, did not see a vote thread (gmail or other clients) > >
he did a separate mail after it was pointed out, that some mail clients (gmail especially) was groupping the vote thread with the rfc thread. maybe this is something that we want to mention in the voting rfc (technically he was doing everything right, having a new mail sent to the list with the [VOTE] in the subject, the problem was that the rest of the subject was identical to the previous discussion thread hence gmail groupped it to the previous thread).
-- Ferenc Kovács @Tyr43l - http://tyrael.hu

Martin Amps

13 years ago
It did appear correctly in the Mail.app client on OSX On Aug 19, 2013, at 1:17 AM, Ferenc Kovacs <tyra3l@gmail.com> wrote:

Igor Wiedler

13 years ago
Hey internals, The two weeks of voting have passed. Voting is now closed. The result of the vote is: 16 "Yes" votes, 4 "No". This translates to 16/20 = 0.8, which is above the required 2/3 majority threshold. As such, I consider this RFC accepted. Thanks for the feedback and support. Both Stas and Nikita pointed out some unhandled edge cases. I will work on resolving those before the patch can be merged, and will ask for another final review once I consider it ready. No significant changes will be needed, so I don't think extending the vote period is necessary. Please let me know if that is not acceptable, in which case it can be extended. Regards, Igor On Aug 15, 2013, at 4:08 PM, Igor Wiedler <igor@wiedler.ch> wrote: