Everything

php

[RFC] [VOTE] Fix inconsistent behavior of $this variable

php.internals

Dmitry Stogov

10 years ago

Hi,

It has been two weeks since discussion started on the RFC to fix inconsistent behavior of $this variable.

This RFC has therefore been moved to "Voting" state.  Voting
began on Jun 6 and will close on June 16.

You can find the full RFC at: <https://wiki.php.net> https://wiki.php.net/rfc/this_var

I encourage everyone to read the RFC and cast your vote towards whichever
option you feel is the best for the language and the community.

Thanks. Dmitry.

Pascal MARTIN

10 years ago

Le 06/06/2016 09:18, Dmitry Stogov a écrit :

>
> You can find the full RFC at: <https://wiki.php.net> https://wiki.php.net/rfc/this_var
>
> I encourage everyone to read the RFC and cast your vote towards whichever
> option you feel is the best for the language and the community.
>

Hi,

At AFUP, we agree the inconsistency outlined in this RFC is quite
strange and fixing it would be nice for the language.

But, we are not sure this should be done in PHP 7.1 (or any other minor
version, actually).

Instead, some of us would be more comfortable with PHP 7.1 (or 7.2, if
it becomes too late for 7.1) adding a deprecation warning. The
inconsistency could then be fixed for 8.0.
This way, no BC-break for 7.x minor versions on this point.

Even if PHP allowing developpers to modify $this is kind of strange and
they shouldn't do it, it still is existing behavior. Is there any rush
of fixing this for end-users, on a minor release?

In any case, thanks for your work on this!

--
Pascal MARTIN, AFUP - French UG
http://php-internals@afup.org

Fleshgrinder

10 years ago

On 6/13/2016 12:48 PM, Pascal MARTIN, AFUP wrote:

> Hi,
>
> At AFUP, we agree the inconsistency outlined in this RFC is quite
> strange and fixing it would be nice for the language.
>
> But, we are not sure this should be done in PHP 7.1 (or any other minor
> version, actually).
>
> Instead, some of us would be more comfortable with PHP 7.1 (or 7.2, if
> it becomes too late for 7.1) adding a deprecation warning. The
> inconsistency could then be fixed for 8.0.
> This way, no BC-break for 7.x minor versions on this point.
>
> Even if PHP allowing developpers to modify $this is kind of strange and
> they shouldn't do it, it still is existing behavior. Is there any rush
> of fixing this for end-users, on a minor release?
>
> In any case, thanks for your work on this!
>

I have to second this concern as with most of the other tiny RFCs going
on right now. This is creating a huge BC chain. Yes, the stuff is weird
but fixing it in a minor is not how this should be approached.

--
Richard "Fleshgrinder" Fussenegger