[RFC][DISCUSSION] SoapClient __getLocation method

php.internals

Silvio Marijić

9 years ago
2016-12-06 15:47 GMT+01:00 Silvio Marijić <marijic.silvio@gmail.com>:
> Here is RFC open for discussion. > > https://wiki.php.net/rfc/soap_get_location > > 2016-12-06 14:48 GMT+01:00 Silvio Marijić <marijic.silvio@gmail.com>: > >> Hi, >> >> I've submited pull request to add a __getLocation to SoapClient. >> Motivation for that was to add a practical way of getting current location >> from SoapClient. >> >> https://github.com/php/php-src/pull/2232 >> >> Any feedback? >> >> Cheers. >> >> -- >> Silvio Marijić >> Software Engineer >> 2e Systems >> > > > > -- > Silvio Marijić > Software Engineer > 2e Systems >
-- Silvio Marijić Software Engineer 2e Systems

Dan Ackroyd

9 years ago
On 6 December 2016 at 14:59, Silvio Marijić <marijic.silvio@gmail.com> wrote:
> https://wiki.php.net/rfc/soap_get_location > https://github.com/php/php-src/pull/2232 > > Any feedback?
Looks good to me. I'm not entirely sure this needs an RFC, but maybe some people have some reason to object to it. The only other thing to note is that ext/soap is an example of an extension that could/should eventually be replaced with a userland replacement and removed from core.....but that is a task for another day. cheers Dan Ack

Silvio Marijić

9 years ago
Hi Dan, Thanks for feedback. I'm not sure about RFC either, but it is a new feature sort of. Cheers, Silvio. On Dec 6, 2016 6:48 PM, "Dan Ackroyd" <danack@basereality.com> wrote: