commit 374f76998 causes getenv to be define with Xdebug loaded

I'll try to check what was wrong with this commit and xdebug. Thanks. Dmitry. ________________________________ From: Joe Watkins <krakjoe@gmail.com> Sent: Wednesday, June 12, 2019 9:38:54 PM To: Derick Rethans Cc: Dmitry Stogov; PHP Developers Mailing List Subject: Re: commit 374f76998 causes getenv to be define with Xdebug loaded Hi all, My clumsy ass reverted that in PHP-7.4, totally and utterly by accident, and since it resolved Dericks problem, I went ahead and reverted in master also rather than make maybe unnecessary noise. Very very sorry about that, I totally intended to get Dmitry's approval/opinion. Terrible form, I'm sorry, I just pushed in the wrong shell. If the revert is terrible, feel free to shout at me and revert the revert. Cheers Joe On Wed, 12 Jun 2019 at 20:04, Derick Rethans <derick@php.net<mailto:derick@php.net>> wrote: Hi Dmitry, I've just fetch the latest PHP-7.4 source from GIT to finalise Xdebug support for it, and after compiling PHP and Xdebug, I now run into the following error: Warning: define() expects at least 2 parameters, 1 given in /home/derick/dev/php/derickr-xdebug/run-xdebug-tests.php on line 2749 Line 2749 is not using define, and instead is: $JUNIT = getenv('TEST_PHP_JUNIT'); I have tracked this down with git bisect to be this commit: https://github.com/php/php-src/commit/374f76998 Could you have a look and let me know what's up? Joe suggests that this might need reverting. cheers, Derick