Everything

php

Bugsnet: Quick fix descriptions

php.internals

Christoph Becker

7 years ago

Hi all,

the quick fix descriptions of bugs.php.net[1] need some update.  To my
knowledge, these come from the database, so could anybody with access to
it please take a look?

Details:

* Try a snapshot

There are no snapshots (except for Windows) any longer; it might make
sense to refer to Git.

* Fixed in SVN

Same as above.

* Fixed in SVN (Website problem)

There are no mirrors any more.

* Fixed in SVN (Doc Build problem)

There are no mirrors any more.

* PHP 4 support discontinued

There should be something like this for PHP 5

[1] <https://bugs.php.net/quick-fix-desc.php>

Thanks,
Christoph

Sara Golemon

7 years ago

On Wed, Jul 17, 2019 at 4:19 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> the quick fix descriptions of bugs.php.net[1] need some update.  To my
> knowledge, these come from the database, so could anybody with access to
> it please take a look?
>
>

Yep. bugdb_resolves table.
How about though, instead of requiring someone with direct DB karma to
update these, we just make an admin page for editing them directly on the
site (for a suitably limited population of logged in php.net users, of
course).
https://bugs.php.net/admin/?action=list_responses is halfway there, just
need a POST handler.

-Sara

Stas Malyshev

7 years ago

Hi!

> the quick fix descriptions of bugs.php.net[1] need some update.  To my
> knowledge, these come from the database, so could anybody with access to
> it please take a look?

Ideally, I think this should be in PHP file and not database, so it will
be modifyable by project members without needing shell access & DB password.

--
Stas Malyshev
smalyshev@gmail.com

Christoph Becker

7 years ago

On 18.07.2019 at 01:14, Stanislav Malyshev wrote:

>> the quick fix descriptions of bugs.php.net[1] need some update.  To my
>> knowledge, these come from the database, so could anybody with access to
>> it please take a look?
>
> Ideally, I think this should be in PHP file and not database, so it will
> be modifyable by project members without needing shell access & DB password.

I agree that this would be the best solution in the long run, and it
shouldn't be hard to adapt ReasonRepository[1] to read from a file
instead of the DB.

Any volunteers?

[1]
<http://git.php.net/?p=web/bugs.git;a=blob;f=src/Repository/ReasonRepository.php;h=b33d60a6bdae13dc78370aa24db481e1101ac13b;hb=HEAD>

Thanks,
Christoph

Peter Cowburn

7 years ago

On Thu, 18 Jul 2019 at 12:10, Christoph M. Becker <cmbecker69@gmx.de> wrote:

> On 18.07.2019 at 01:14, Stanislav Malyshev wrote:
>
> >> the quick fix descriptions of bugs.php.net[1] need some update.  To my
> >> knowledge, these come from the database, so could anybody with access to
> >> it please take a look?
> >
> > Ideally, I think this should be in PHP file and not database, so it will
> > be modifyable by project members without needing shell access & DB
> password.
>
> I agree that this would be the best solution in the long run, and it
> shouldn't be hard to adapt ReasonRepository[1] to read from a file
> instead of the DB.
>
> Any volunteers?
>

I'm not sure if anyone other than us is still using this source code
(looking at the MySQL guys).  If not, can we just include the reasons in
the source directly, and forget about the database or a special file
containing the reasons?

Pieter Hordijk

7 years ago

Hey all,

I think we can just add the reasons to the file where it is being rendered.

I am off for the weekend, but I can implement and test this after the weekend
if nobody else picked it up by then.

Pieter

----- Original Message -----

Johannes Schlueter

7 years ago

On Thu, 2019-07-18 at 12:24 +0100, Peter Cowburn wrote:

> I'm not sure if anyone other than us is still using this source code
> (looking at the MySQL guys).  If not, can we just include the reasons
> in
> the source directly, and forget about the database or a special file
> containing the reasons?
>

MySQL's version heavily diverged 15+ years ago. No need to look at
compatibility. :-)

imo the php.net bug tracker should focus on php.net's needs.

johannes

Sara Golemon

7 years ago

On Thu, Jul 18, 2019 at 6:10 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> I agree that this would be the best solution in the long run, and it
> shouldn't be hard to adapt ReasonRepository[1] to read from a file
> instead of the DB.
>
> Any volunteers?
>
> [1]
> <
> http://git.php.net/?p=web/bugs.git;a=blob;f=src/Repository/ReasonRepository.php;h=b33d60a6bdae13dc78370aa24db481e1101ac13b;hb=HEAD
> >
>
> Sure.

https://github.com/php/web-bugs/commit/4b52935a8675d6ff6d5b06258e6c74ef135fad35

Christoph Becker

7 years ago

On 18.07.2019 at 16:25, Sara Golemon wrote:

> On Thu, Jul 18, 2019 at 6:10 AM Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
>
>> I agree that this would be the best solution in the long run, and it
>> shouldn't be hard to adapt ReasonRepository[1] to read from a file
>> instead of the DB.
>>
>> Any volunteers?
>>
>> [1]
>> <
>> http://git.php.net/?p=web/bugs.git;a=blob;f=src/Repository/ReasonRepository.php;h=b33d60a6bdae13dc78370aa24db481e1101ac13b;hb=HEAD
>
> Sure.
> https://github.com/php/web-bugs/commit/4b52935a8675d6ff6d5b06258e6c74ef135fad35

Thanks!