On Fri, Aug 23, 2019 at 11:25 AM Zeev Suraski <zeev@zend.com> wrote:
>
> On 23 Aug 2019, at 10:56, Zeev Suraski <zeev@zend.com> wrote:
>
>
>
> On 23 Aug 2019, at 10:33, Nikita Popov <nikita.ppv@gmail.com> wrote:
>
>
> Hi internals,
>
>
> We currently have separate karma for the Zend/TSRM directories in php-src.
>
> I think this separation has become more annoying than useful at this point.
>
> Most changes from newer contributors are approved on GitHub first, and we
>
> often have to grant some form of Zend karma for tests if nothing else
>
> anyway.
>
>
> Any objections to dropping this and have a single php-src karma for the
>
> whole tree (with the exception of php_version.h, which is used to prevent
>
> bad merges)?
>
>
>
> No objections here - the separation is fairly meaningless nowadays.
>
>
> On second reading, do you mean to merge the Zend/TSRM into one, or so away
> with both altogether? I initially read it as the former but based on the
> reasoning I think you probably meant the latter..? Personally, given the
> complexity I think this level of granularity makes sense - do we really
> have that many folks that should have direct access there?
>
> Zeev
>
Zend/TSRM already have shared karma, I'm suggesting to merge it into
php-src karma. Complexity is pretty meaningless here, as changes need to be
reviewed anyway. Zend/ isn't different from other code in that respect. We
also have plenty of other complex code outside of Zend, such as ext/opcache.
Nikita
