Warn when declaring required parameter after optional one

Error(in PHP 8) after warning or deprecation in 7.xnything more preferred… --- Sent from Mail for Windows 10 From: Olumide Samson Sent: Saturday, January 11, 2020 2:42 PM To: Niklas Keller; Nikita Popov Cc: Bob Weinand; PHP internals Subject: RE: [PHP-DEV] Warn when declaring required parameter afteroptionalone Should it be a warning or an error? --- Sent from Mail for Windows 10 From: Niklas Keller Sent: Saturday, January 11, 2020 2:35 PM To: Nikita Popov Cc: Bob Weinand; PHP internals Subject: Re: [PHP-DEV] Warn when declaring required parameter after optionalone Hi Nikita, while this is a rather small change, it has quite some BC impact, as not all old code has been adjusted to run on PHP 7.1+ only using nullable types. I'd like to see an RFC with a vote for this. Regards, Niklas

Hi all, Whilst I totally see the benefits of this, I'm not sure if this is a job for PHP itself, rather a coding standard enforced optionally by something like PHPCS. It's certainly a bad practice, but I'm not sure the benefit will be worth the refactors required. I feel we might be an interesting example, however, it'd cause us a lot of pain for the following reason: We have a portion of our codebase (shared over hundreds of websites) which is symlinked into each of the websites so the core functionality can be easily updated when required on all sites. These sites are staggered at present across multiple PHP versions whilst being migrated (and due to the number of sites to migrate, they will be for some time). If this change were to come into effect, the same code we've safely had symlinked running across multiple PHP versions would suddenly become incompatible on the latest version, with no easy way to be suppressed which would mean we have to fork things and maintain two codebases. I appreciate this isn't likely to be a normal workflow for people, but it is an example of how it could cause unintended pain. Just my thoughts anyway. Cheers, Aran On Fri, 17 Jan 2020 at 18:00, Nikita Popov <nikita.ppv@gmail.com> wrote:

On Fri, Jan 17, 2020 at 11:59 AM Nikita Popov <nikita.ppv@gmail.com> wrote: >> I've created https://github.com/php/php-src/pull/5067 to make code like >> function test($foo = null, $bar) {} >> throw a warning > > I was interested in seeing how prevalent this pattern, is, so I ran > some analysis on the top 2k composer packages. I found 527 signatures > that would throw a deprecation warning with this change. Of these 187 > are potentially used as "poor man's nullable types" (the optional > argument has both a type and a null default), while the other 340 are > definite bugs. Given that most of these usages are definite bugs, I'm in favor of deprecating this in PHP 8 and making it a compile error in PHP 9. This should provide plenty of time for codebases to migrate to the simpler nullable types syntax for the minority of usages that aren't bugs. Theodore