Everything

php

[VOTE] Shorter Attributes Syntax Change

php.internals

Benjamin Eberlei

6 years ago

Hello everyone,

We have started the vote on "Shorter Attributes Syntax Change" RFC to
decide one last time on what syntax to choose for the Attributes feature.

https://wiki.php.net/rfc/shorter_attribute_syntax_change#voting

The first vote is a vote to say that you have an opinion about attribute
syntax.

The second vote is an STV vote.

In STV you SHOULD rank *all* choices, but don't pick the same one more
than once, as that will invalidate your vote.

Please see the introduction for multiple arguments on why we should revote.

In addition to the table and Syntax Side by Side giving an overview on the
differences of each syntax, there is also an extensive discussion of the
various arguments below.

Thank you to everyone participating in the discussion.

The vote ends September 2nd, 12:00 UTC.

cheers,
Derick and Benjamin

Theodore Brown

6 years ago

Hi Benjamin,

Thank you again for putting in the effort to update the RFC and
address most of the arguments brought up on list.

I would encourage everyone to read through the complete RFC before
voting, particularly the sections on BC breaks and forward
compatibility pros/cons. Top link:
https://wiki.php.net/rfc/shorter_attribute_syntax_change

The @{} syntax hasn't had much discussion yet. While I think it is
better than @[] and #[] since it doesn't break BC, it still shares
the problem of looking like a standalone block, when really
attributes are part of a class/function/property/etc. declaration.

Now that voters have the complete information, it's up to them to
make a final decision. I look forward to putting this issue behind us!

Best regards,  
Theodore

Benjamin Eberlei

6 years ago

I wanted to clarify that this is the **restarted* vote on Shorter Attribute
Syntax Change, that means all votes cast between August 11th and 15th have
been reset.

On Wed, Aug 19, 2020 at 12:50 PM Benjamin Eberlei <kontakt@beberlei.de>
wrote:

Theodore Brown

6 years ago

On Wed, Aug 19, 2020 at 11:09 AM Benjamin Eberlei <kontakt@beberlei.de> wrote:

> I wanted to clarify that this is the **restarted* vote on Shorter
> Attribute Syntax Change, that means all votes cast between August
> 11th and 15th have been reset.

In case anyone wants to view the in-progress STV vote results, I took
the same script I made for the Shorter Attribute Syntax RFC and made
it possible to run online here:

https://stv-results.theodorejb.me/php/?rfc=shorter_attribute_syntax_change

Note that at present it only processes the STV vote and ignores the
primary 2/3 poll result, so keep that in mind.

Best regards,  
Theodore

Côme Chilliet

6 years ago

Le Wed, 19 Aug 2020 21:11:29 +0000,
Theodore Brown <theodorejb@outlook.com> a écrit :

> In case anyone wants to view the in-progress STV vote results, I took
> the same script I made for the Shorter Attribute Syntax RFC and made
> it possible to run online here:
>
> https://stv-results.theodorejb.me/php/?rfc=shorter_attribute_syntax_change
>
> Note that at present it only processes the STV vote and ignores the
> primary 2/3 poll result, so keep that in mind.

Thank you, I was searching for something like this!

Is there any chance we can see the code? (mostly out of curiosity)

Also, is it supposed to be updated at page load or at some time interval?
I see 15 votes on the RFC page for #[] and 14 on your page.

Côme

Benjamin Eberlei

6 years ago

On Thu, Aug 20, 2020 at 9:13 AM Côme Chilliet <
come.chilliet@fusiondirectory.org> wrote:

> Le Wed, 19 Aug 2020 21:11:29 +0000,
> Theodore Brown <theodorejb@outlook.com> a écrit :
> > In case anyone wants to view the in-progress STV vote results, I took
> > the same script I made for the Shorter Attribute Syntax RFC and made
> > it possible to run online here:
> >
> >
> https://stv-results.theodorejb.me/php/?rfc=shorter_attribute_syntax_change
> >
> > Note that at present it only processes the STV vote and ignores the
> > primary 2/3 poll result, so keep that in mind.
>
> Thank you, I was searching for something like this!
>
> Is there any chance we can see the code? (mostly out of curiosity)
>
> Also, is it supposed to be updated at page load or at some time interval?
> I see 15 votes on the RFC page for #[] and 14 on your page.
>

With 30 voters its likely one voted for the same thing twice accidentally
and the vote is disqualified. Afaik Derick's script outputs that so the
voter can be notified about their mistake.

Côme Chilliet

6 years ago

Le Thu, 20 Aug 2020 10:37:21 +0200,
Benjamin Eberlei <kontakt@beberlei.de> a écrit :

> On Thu, Aug 20, 2020 at 9:13 AM Côme Chilliet <
> come.chilliet@fusiondirectory.org> wrote:
> > Also, is it supposed to be updated at page load or at some time interval?
> > I see 15 votes on the RFC page for #[] and 14 on your page.
> >
>
> With 30 voters its likely one voted for the same thing twice accidentally
> and the vote is disqualified. Afaik Derick's script outputs that so the
> voter can be notified about their mistake.

Indeed, jwage voted for #[] as both 1st and 3rd choice.

Thanks for the explanation.

Theodore Brown

6 years ago

On Thu, Aug 20, 2020 at 2:13 AM
Côme Chilliet <come.chilliet@fusiondirectory.org> wrote:

> Le Wed, 19 Aug 2020 21:11:29 +0000, 
> Theodore Brown <theodorejb@outlook.com> a écrit :
> > In case anyone wants to view the in-progress STV vote results, I took
> > the same script I made for the Shorter Attribute Syntax RFC and made
> > it possible to run online here:
> >
> > https://stv-results.theodorejb.me/php/?rfc=shorter_attribute_syntax_change
> >
> > Note that at present it only processes the STV vote and ignores the
> > primary 2/3 poll result, so keep that in mind.
> 
> Thank you, I was searching for something like this!
> 
> Is there any chance we can see the code? (mostly out of curiosity)

Hi Côme,

Ask, and you will receive! https://github.com/theodorejb/php-stv

> Also, is it supposed to be updated at page load or at some time
> interval? I see 15 votes on the RFC page for #[] and 14 on your page.

It's currently updated on page load. As Benjamin suggested, there are
some invalid ballots right now where the same candidate was selected
more than once. You can view these by adding a `&showInvalid=1`
parameter to the URL. You can also have it output all counted ballots
by adding `&showCounted=1` to the URL.

Note that the webpage works for other STV elections. If you set the
`rfc` parameter to "shorter_attribute_syntax", you can view the
results of the original Shorter Attribute Syntax RFC. If you replace
this parameter with `?election=todo/php80` you can view the PHP 8.0
release manager election results. [1]

Interestingly, it looks like Gabriel won this election rather than it
being a tie as was announced on list. [2] My guess is that Derick
possibly tallied the results before the poll was actually closed 
which caused a vote to be missed? At least the result didn't change
in the subsequent vote!

Kind regards,  
Theodore

[1]: https://stv-results.theodorejb.me/php/?election=todo/php80
[2]: https://externals.io/message/109552#109756

Derick Rethans

5 years ago

Hi,

This vote has now been concluded. The primary vote to re-choose with STV
was accepted, with 50 for and 11 against.

The STV selection selected the syntax:

#[Attr]

The full STV run is at
https://gist.github.com/3c1f41afbabdeaa0c12753397833db8c

Thanks all for participating and voting. The implementation won't make
into 8.0.0beta3 as this has already been tagged and build, so the new
syntax will be part of PHP 8.0.0RC1, due in 15 days.

cheers,
Derick

--
PHP 7.4 Release Manager
Host of PHP Internals News: https://phpinternals.news
Like Xdebug? Consider supporting me: https://xdebug.org/support
https://derickrethans.nl | https://xdebug.org | https://dram.io
twitter: @derickr and @xdebug