Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Rename Fiber::this() to Fiber::getCurrent() »

Rename Fiber::this() to Fiber::getCurrent()

php.internals

Aaron Piotrowski

5 years ago
Hi all, During the Fiber RFC vote, several people noted that they objected to the name Fiber::this() for the method returning the currently executing Fiber object. I'd like to propose renaming this method to Fiber::getCurrent(). A simple PR for the rename: https://github.com/php/php-src/pull/7155 Nothing has functionally changed about the method, only the name. Fiber::current() is another possibility, but was not chosen because it may be conflated with Iterator::current(). Does anyone object to this rename? Shall we have a vote or is that not necessary? Cheers, Aaron Piotrowski

Larry Garfield

5 years ago
On Tue, Jun 15, 2021, at 2:01 PM, Aaron Piotrowski wrote:
> Hi all, > > During the Fiber RFC vote, several people noted that they objected to > the name Fiber::this() for the method returning the currently executing > Fiber object. > > I'd like to propose renaming this method to Fiber::getCurrent(). A > simple PR for the rename: https://github.com/php/php-src/pull/7155 > Nothing has functionally changed about the method, only the name. > > Fiber::current() is another possibility, but was not chosen because it > may be conflated with Iterator::current(). > > Does anyone object to this rename? Shall we have a vote or is that not > necessary? > > Cheers, > Aaron Piotrowski
I support this change, and don't think it needs an RFC. I would vote for it if it were necessary, though. --Larry Garfield

Joe Watkins

5 years ago
This doesn't look like the sort of detail we need to vote on. It would be nice if this were made in time for the migration guide and other doc to be prepared for 8.1. Let's move forward, please ... Cheers Joe On Tue, 15 Jun 2021 at 21:54, Larry Garfield <larry@garfieldtech.com> wrote: