Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [Pre-Vote Announcement] Move RNG functions Random Extension »

[Pre-Vote Announcement] Move RNG functions Random Extension

php.internals

zeriyoshi

4 years ago
The voting phase for the following RFCs will begin as soon as two weeks have passed. https://externals.io/message/115975 I don't see any particular discussion, so I'm contacting you just in case. Best regards. Go Kudo

A.L.E.C

4 years ago
On 22.09.2021 13:21, Go Kudo wrote:
> The voting phase for the following RFCs will begin as soon as two weeks > have passed.
The RFC title is not correct English (missing "to" or "into"). The first paragraph in Introduction is also hard to read.
-- Aleksander Machniak Kolab Groupware Developer [https://kolab.org] Roundcube Webmail Developer [https://roundcube.net] ---------------------------------------------------- PGP: 19359DC1 # Blog: https://kolabian.wordpress.com

zeriyoshi

4 years ago
2021年9月22日(水) 21:01 Aleksander Machniak <alec@alec.pl>:
> On 22.09.2021 13:21, Go Kudo wrote: > > The voting phase for the following RFCs will begin as soon as two weeks > > have passed. > > The RFC title is not correct English (missing "to" or "into"). The first > paragraph in Introduction is also hard to read. > > -- > Aleksander Machniak > Kolab Groupware Developer [https://kolab.org] > Roundcube Webmail Developer [https://roundcube.net] > ---------------------------------------------------- > PGP: 19359DC1 # Blog: https://kolabian.wordpress.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: https://www.php.net/unsub.php > >
Sorry. I'm not native English speaker and I am not good at English. I have improved the title first. I don't know how to fix the first chapter, so I left it as it is. If this causes problems in the voting phase of the RFC, I will try to fix it further, how about that?

Nikita Popov

4 years ago
On Wed, Sep 22, 2021 at 1:21 PM Go Kudo <zeriyoshi@gmail.com> wrote:
> The voting phase for the following RFCs will begin as soon as two weeks > have passed. > > https://externals.io/message/115975 > > I don't see any particular discussion, so I'm contacting you just in case. >
I'm pretty neutral on this proposal. I don't think there's a strong motivation to move this functionality into a separate extension, but I also don't see any particular problems with doing it (as long as it's an always-required extension, which this is). I believe Levi is a proponent of splitting up ext/standard into smaller extensions, maybe he has some thoughts on this. Regards, Nikita

Unnamed Person

4 years ago
On Mon, Oct 4, 2021 at 4:21 AM Nikita Popov <nikita.ppv@gmail.com> wrote:
> > On Wed, Sep 22, 2021 at 1:21 PM Go Kudo <zeriyoshi@gmail.com> wrote: >> >> The voting phase for the following RFCs will begin as soon as two weeks >> have passed. >> >> https://externals.io/message/115975 >> >> I don't see any particular discussion, so I'm contacting you just in case. > > > I'm pretty neutral on this proposal. I don't think there's a strong motivation to move this functionality into a separate extension, but I also don't see any particular problems with doing it (as long as it's an always-required extension, which this is). > > I believe Levi is a proponent of splitting up ext/standard into smaller extensions, maybe he has some thoughts on this. > > Regards, > Nikita
I've glanced at the patch; it seems fine. I do like smaller, focused extensions better than throwing things in `ext/standard`. Can we change the return types of the functions in this extension returning `SUCCESS`/`FAILURE` to `zend_result` at the same time? I think it's just these two: - php_random_bytes - php_random_int Actually, is that something we could still do for PHP 8.1?