Everything

php

[RFC] [Discussion] Change how JIT is disabled by default

php.internals

Daniil Gentili

2 years ago

Hi all,

I would like to submit an RFC and PR to change a few INI defaults for
opcache, changing how JIT is disabled by default.

Here's the URL of the RFC: https://wiki.php.net/rfc/jit_config_defaults.

I'd more more than glad to receive some feedback!

Regards,

Daniil Gentili.

Dmitry Stogov

2 years ago

Hi Daniil,

Currently JIT may be disabled by setting "opcache.jit=disable" or
"opcache.jit_buffer_size=0".
Many PHP installations have php.ini with the current default settings
"opcache.jit=tracing" and "opcache.jit_buffer_size=0".
After upgrading to the new PHP version with this patch, all of them won't
be able to start PHP.

I don't care a lot about the php.ini defaults, but I don't like to give our
users a headache.

Thanks. Dmitry.

After your patch

On Wed, Nov 15, 2023 at 10:35 PM Daniil Gentili <daniil@daniil.it> wrote:

Daniil Gentili

2 years ago

Hi Dmitry,

> After upgrading to the new PHP version with this patch, all of them won't
> be able to start PHP.
>
> I don't care a lot about the php.ini defaults, but I don't like to give our
> users a headache.

No problem, I can change the defaults but remove the fatal error if
jit=non-zero and jit_buffer_size=0, can I still turn it into a warning
though?


Regards,

Daniil Gentili.

A.L.E.C

2 years ago

On 16.11.2023 10:21, Daniil Gentili wrote:

> No problem, I can change the defaults but remove the fatal error if
> jit=non-zero and jit_buffer_size=0, can I still turn it into a warning
> though?

Whatever you do, please mention it in the Proposal section of the RFC.

--
Aleksander Machniak
Kolab Groupware Developer        [https://kolab.org]
Roundcube Webmail Developer  [https://roundcube.net]
----------------------------------------------------
PGP: 19359DC1 # Blog: https://kolabian.wordpress.com

Dmitry Stogov

2 years ago

> No problem, I can change the defaults but remove the fatal error if
> jit=non-zero and jit_buffer_size=0, can I still turn it into a warning
> though?
>

I think we don't need the warning. It's clear that JIT won't work with
"opcache.jit_buffer_size=0" in php.ini.

Thanks. Dmitry.

Daniil Gentili

2 years ago

16 nov 2023 10:28:16 Dmitry Stogov <dmitrystogov@gmail.com>:

>> No problem, I can change the defaults but remove the fatal error if
>> jit=non-zero and jit_buffer_size=0, can I still turn it into a warning
>> though?
>>
>
> I think we don't need the warning. It's clear that JIT won't work with
> "opcache.jit_buffer_size=0" in php.ini.
>
> Thanks. Dmitry.

Hi,
All done, updated both RFC and pull request :)

Regards,
Daniil Gentili

Daniil Gentili

2 years ago

Hi all,

Heads up, I'll move this RFC
(https://wiki.php.net/rfc/jit_config_defaults) to voting status tomorrow!

Regards,

Daniil Gentili.