Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [DISCUSSION] Fix mb_trim inaccurate $character »

[DISCUSSION] Fix mb_trim inaccurate $character

php.internals

youkidearitai

2 years ago
Hi, Internals Found two problem with mb_trim, mb_ltrim and mb_rtrim functions. - https://github.com/php/php-src/issues/13789 - https://github.com/php/php-src/issues/13815 Therefore, I think require an RFC, I have written a draft an RFC that fixes these issues. https://wiki.php.net/rfc/mb_trim_change_characters Feel free to comments on this. Regards Yuya
-- --------------------------- Yuya Hamada (tekimen) - https://tekitoh-memdhoi.info - https://github.com/youkidearitai -----------------------------

Tim Düsterhus

2 years ago
Hi On 4/3/24 10:02, youkidearitai wrote:
> Therefore, I think require an RFC, I have written a draft an RFC that > fixes these issues. > https://wiki.php.net/rfc/mb_trim_change_characters
I don't think this (widening the type and changing the default value to obtain the *intended* behavior) requires an RFC. It's a bugfix, a bugfix with a slightly larger observable impact than other bugfixes. Best regards Tim Düsterhus

youkidearitai

2 years ago
2024年4月4日(木) 6:30 Tim Düsterhus <tim@bastelstu.be>:
> > Hi > > On 4/3/24 10:02, youkidearitai wrote: > > Therefore, I think require an RFC, I have written a draft an RFC that > > fixes these issues. > > https://wiki.php.net/rfc/mb_trim_change_characters > > I don't think this (widening the type and changing the default value to > obtain the *intended* behavior) requires an RFC. It's a bugfix, a bugfix > with a slightly larger observable impact than other bugfixes. > > Best regards > Tim Düsterhus
Hi Thank you very much for comment. I would like to discuss this RFC with all of you, as we have not yet decided on the correct revision policy. I created the RFC for that purpose. Still waiting for your comments! Thank you. Yuya
-- --------------------------- Yuya Hamada (tekimen) - https://tekitoh-memdhoi.info - https://github.com/youkidearitai -----------------------------

Nicolas Grekas

2 years ago
Hi Le jeu. 4 avr. 2024 à 07:41, youkidearitai <youkidearitai@gmail.com> a écrit :
> 2024年4月4日(木) 6:30 Tim Düsterhus <tim@bastelstu.be>: > > > > Hi > > > > On 4/3/24 10:02, youkidearitai wrote: > > > Therefore, I think require an RFC, I have written a draft an RFC that > > > fixes these issues. > > > https://wiki.php.net/rfc/mb_trim_change_characters > > > > I don't think this (widening the type and changing the default value to > > obtain the *intended* behavior) requires an RFC. It's a bugfix, a bugfix > > with a slightly larger observable impact than other bugfixes. > > > > Best regards > > Tim Düsterhus > > Hi > Thank you very much for comment. > > I would like to discuss this RFC with all of you, as we have not yet > decided on the correct revision policy. > I created the RFC for that purpose. > > Still waiting for your comments! > Thank you. > >
I also don't think this requires an RFC. This is a minor design issue that has only one possible solution, so there is little to discuss. Cheers, Nicolas

youkidearitai

2 years ago
2024年4月12日(金) 18:32 Nicolas Grekas <nicolas.grekas+php@gmail.com>:
> > Hi > > Le jeu. 4 avr. 2024 à 07:41, youkidearitai <youkidearitai@gmail.com> a écrit : >> >> 2024年4月4日(木) 6:30 Tim Düsterhus <tim@bastelstu.be>: >> > >> > Hi >> > >> > On 4/3/24 10:02, youkidearitai wrote: >> > > Therefore, I think require an RFC, I have written a draft an RFC that >> > > fixes these issues. >> > > https://wiki.php.net/rfc/mb_trim_change_characters >> > >> > I don't think this (widening the type and changing the default value to >> > obtain the *intended* behavior) requires an RFC. It's a bugfix, a bugfix >> > with a slightly larger observable impact than other bugfixes. >> > >> > Best regards >> > Tim Düsterhus >> >> Hi >> Thank you very much for comment. >> >> I would like to discuss this RFC with all of you, as we have not yet >> decided on the correct revision policy. >> I created the RFC for that purpose. >> >> Still waiting for your comments! >> Thank you. >> > > I also don't think this requires an RFC. This is a minor design issue that has only one possible solution, so there is little to discuss. > > Cheers, > Nicolas
Hi, I appreciate late my response. I got it. I modified original an RFC (https://wiki.php.net/rfc/mb_trim) that $character is default parameter. Please point out any problems, I revert it. Regards Yuya
-- --------------------------- Yuya Hamada (tekimen) - https://tekitoh-memdhoi.info - https://github.com/youkidearitai -----------------------------

Joerg Sowa

2 years ago
Hello Yuya, I don't think modifying voted RFCs is allowed despite the size of the change. Moreover, there are no dates of the voting included in the description of the RFC so it's not clear for visitors when exactly the RFC has been approved. Kind regards, Jorg

youkidearitai

2 years ago
2024年4月15日(月) 17:32 Jorg Sowa <jorg.sowa@gmail.com>:
> > Hello Yuya, > I don't think modifying voted RFCs is allowed despite the size of the change. Moreover, there are no dates of the voting included in the description of the RFC so it's not clear for visitors when exactly the RFC has been approved. > > Kind regards, > Jorg
Hi, Jorg Thank you very much.
> I don't think modifying voted RFCs is allowed despite the size of the change. Moreover, there are no dates of the voting included in the description of the RFC so it's not clear for visitors when exactly the RFC has been approved.
It was not good. Restored original an RFC. Thank you Yuya
-- --------------------------- Yuya Hamada (tekimen) - https://tekitoh-memdhoi.info - https://github.com/youkidearitai -----------------------------