Everything

php

Home » Project » Newsgroups » php.internals » [VOTE] Correctly name the rounding mode and make it an Enum »

[VOTE] Correctly name the rounding mode and make it an Enum

php.internals

Tim Düsterhus

2 years ago

Hi

I've just opened the vote for the "Correctly name the rounding mode and
make it an Enum" RFC. The RFC contains a single vote which requires a
2/3 majority to pass. Voting runs 2 weeks until 2024-07-17 07:00 UTC.

Please find the following resources for your references:

RFC Text:
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
Discussion Thread: https://externals.io/message/123472

Best regards
Tim Düsterhus

Tim Düsterhus

2 years ago

Hi

On 7/3/24 08:32, Tim Düsterhus wrote:

> RFC Text:
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
> Discussion Thread: https://externals.io/message/123472

I have just added a link to the implementation of the enum and the
changes to `round()` to the RFC. Saki will handle the changes to ext/bcmath.

You can find my PR at: https://github.com/php/php-src/pull/14833

I have also fixed an error in the explanation of the 'PositiveInfinity'
rounding mode [1]. It previously read:

> Round to the largest integer that is greater or equal.

but it should read:

> Round to the ***smallest*** integer that is greater or equal.

I apologize for the confusion this may have caused.

Best regards
Tim Düsterhus

[1]
https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum?do=diff&rev2%5B0%5D=1720182318&rev2%5B1%5D=1720182387&difftype=sidebyside

Tim Düsterhus

2 years ago

Hi

On 7/3/24 08:32, Tim Düsterhus wrote:

> RFC Text:
> https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum
> Discussion Thread: https://externals.io/message/123472
>

The RFC has been accepted unanimously with 34 (yes) to 0 (no) votes.

I'll now make the final adjustments to the implementation and then merge it.

Best regards
Tim Düsterhus