Everything

php

Lock down old bug tracker to developers only?

php.internals

Christoph Becker

2 years ago

Hi all!

I think the proper mailing list to discuss this is php-webmaster, but
since many whom this may concern are not subscribed there, so I'm
cross-posting to internals, too.  Sorry if this is not appropriate.

Quite a while ago, Damian had suggested to "don't allow any further
edits, comments, uploads, or other activity except by php.net developer
accounts."[1]  In my opinion, this is overdue, so after a very brief
"discussion" on this ticket, I submitted a respective PR[2].

Now, of course, this should be properly discussed on a mailing list, so
I'm sending this mail.

Does anybody have objections on proceeding with this, or maybe other
remarks?

[1] <https://github.com/php/web-bugs/issues/114>
[2] <https://github.com/php/web-bugs/pull/120>

Cheers,
Christoph

Jim Winstead

2 years ago

On Sat, Jul 20, 2024, at 10:20 AM, Christoph M. Becker wrote:

> Quite a while ago, Damian had suggested to "don't allow any further
> edits, comments, uploads, or other activity except by php.net developer
> accounts."[1]  In my opinion, this is overdue, so after a very brief
> "discussion" on this ticket, I submitted a respective PR[2].
>
> Now, of course, this should be properly discussed on a mailing list, so
> I'm sending this mail.
>
> Does anybody have objections on proceeding with this, or maybe other
> remarks?

Yes, I think this is a good next step to take. (I haven't reviewed the actual pull request closely, but it looks good at first glance.)

On the php-webmaster side, I think the discussion needs to continue on how we handle some of these legacy websites that should become read-only, and bugs is probably at the top of that list. But we don't need to drag internals@ along for that.

Jim

Christoph Becker

2 years ago

On 20.07.2024 at 19:20, Christoph M. Becker wrote:

> I think the proper mailing list to discuss this is php-webmaster, but
> since many whom this may concern are not subscribed there, so I'm
> cross-posting to internals, too.  Sorry if this is not appropriate.
>
> Quite a while ago, Damian had suggested to "don't allow any further
> edits, comments, uploads, or other activity except by php.net developer
> accounts."[1]  In my opinion, this is overdue, so after a very brief
> "discussion" on this ticket, I submitted a respective PR[2].
>
> Now, of course, this should be properly discussed on a mailing list, so
> I'm sending this mail.
>
> Does anybody have objections on proceeding with this, or maybe other
> remarks?
>
> [1] <https://github.com/php/web-bugs/issues/114>
> [2] <https://github.com/php/web-bugs/pull/120>

Since nobody raised objections, I assume we can proceed with this now.
I would like to get some feedback on the PR[2], though, since the code
is completely untested (sorry, I do not have a development environment
set up for web-bugs, and would rather not spend much time on this).

Thanks,
Christoph

Christoph Becker

2 years ago

On 29.07.2024 at 12:59, Christoph M. Becker wrote:

> On 20.07.2024 at 19:20, Christoph M. Becker wrote:
>
>> Quite a while ago, Damian had suggested to "don't allow any further
>> edits, comments, uploads, or other activity except by php.net developer
>> accounts."[1]  In my opinion, this is overdue, so after a very brief
>> "discussion" on this ticket, I submitted a respective PR[2].
>>
>> [1] <https://github.com/php/web-bugs/issues/114>
>> [2] <https://github.com/php/web-bugs/pull/120>

The PR has been merged a couple of hours ago. That means:

* for normal users the bug tracker is now read-only, except that they
can link to pull requests.  Voting on bugs is completely disabled for
everbody.

* the original bug reporter is also allowed to edit the original post.

* developers are still allowed to add comments, add patches, link pull
request etc.; i.e. no new restrictions are imposed on them.

Since the code base of the old bug tracker does not conform to
contemporary coding practises, and due to time constraints, only some
limited testing of the changes could be done (thank you very much,
Derick, for doing this!), so some of the new behavior may not be as
intended.  If you notice any issues, please file a ticket at
<https://github.com/php/web-bugs/issues>, or perhaps even better, submit
a pull request at <https://github.com/php/web-bugs/pulls>.

Also note that it wouldn't make sense to do some refactoring or general
improvements to the code base; the long term goal should still be to
archive the bug tracker (i.e. make it read-only for everyone, even
developers).  As such, please don't file new issues or pull request for
that.  Only focused (minor) fixes appear to make sense at this point.

Cheers,
Christoph