Everything

php

[RFC] [VOTE] Warnings for PHP 8.5

php.internals

Gina P. Banyard

1 year ago

Hello internals,

I have opened the votes for the warnings:
https://wiki.php.net/rfc/warnings-php-8-5

The vote will run for two weeks until the 12th of August 2025.

Please remember that the wiki is only capable to handle a single vote at a time,
so please submit each vote you intend on casting individually.

Best regards,

Gina P. Banyard

Jakub Zelenka

1 year ago

Hi,

On Tue, Jul 29, 2025 at 11:07 AM Gina P. Banyard <internals@gpb.moe> wrote:

> Hello internals,
>
> I have opened the votes for the warnings:
> https://wiki.php.net/rfc/warnings-php-8-5
>
>

Just for the record I voted No on those isset and empty warnings as I don't
think they should be emitting warning in this case - it might be quite
surprising for users and have a BC impact for them (e.g. they might be
checking output from internals functions where false is returned and
currently they don't need to care for that which I think make more sense
for those functions).

Kind regards,

Jakub

Gina P. Banyard

1 year ago

Hello internals,

I have now closed the votes for the "Warnings for PHP 8.5" RFC:
https://wiki.php.net/rfc/warnings-php-8-5

The following proposals have been accepted:

- Warn when coercing NAN to other types (20 yay, 0 nay, 100%)
- Casting out of range floats to int (17 yay, 0 nay, 100%)
- Destructuring non-array values (16 yay, 0 nay, 100%)

The following proposals have been declined:

- Warn when using offsets on non-container values in isset()/empty() (10 yay, 6 nay, 62.5%)
- Warn when using invalid offset types when checking string offsets with isset()/empty() (10 yay, 6 nay, 62.5%)

Thank you to everyone that has voted and participated in the discussions.

Best regards,

Gina P. Banyard