Everything

php

SNMP module RFC implementation

php.internals

swilton@fluentit.au

90 days ago

Hi,

I have gone through the RFC process for a bunch of new functionality for
the SNMP module and wanted to check if there's anything else I need to
do to move this forward, or if it's in the queue and waiting for the
appropriate releases?

Tim Düsterhus

82 days ago

Hi

Am 2026-06-03 13:04, schrieb Steven Wilton:

> I have gone through the RFC process for a bunch of new functionality
> for the SNMP module and wanted to check if there's anything else I need
> to do to move this forward, or if it's in the queue and waiting for the
> appropriate releases?

As I indicated in your thread about the “SNMP MIB reset function”, SNMP
is pretty obscure, which likely also makes it hard to find reviewers.
Personally I'll not be able to do that meaningfully and don't have the
time to learn SNMP.

That said, I just reached out in Foundation Slack to hopefully find
someone (from the Foundation) to review your PRs.

I suspect it would definitely help if you could clean up the commit
history, rebase the PRs to the latest master and to undraft them for
those you are comfortable with being reviewed. Please make sure to
include a link to your RFC in the commit message and PR description to
make it easy for the reviewer to cross-reference the implementation
against what you proposed in the RFC.

Best regards
Tim Düsterhus

swilton@fluentit.au

79 days ago

On 11/06/2026 9:08 pm, Tim Düsterhus wrote:

> Hi
>
> Am 2026-06-03 13:04, schrieb Steven Wilton:
>> I have gone through the RFC process for a bunch of new functionality
>> for the SNMP module and wanted to check if there's anything else I
>> need to do to move this forward, or if it's in the queue and waiting
>> for the appropriate releases?
>
> As I indicated in your thread about the “SNMP MIB reset function”,
> SNMP is pretty obscure, which likely also makes it hard to find
> reviewers. Personally I'll not be able to do that meaningfully and
> don't have the time to learn SNMP.
>
> That said, I just reached out in Foundation Slack to hopefully find
> someone (from the Foundation) to review your PRs.
>
> I suspect it would definitely help if you could clean up the commit
> history, rebase the PRs to the latest master and to undraft them for
> those you are comfortable with being reviewed. Please make sure to
> include a link to your RFC in the commit message and PR description to
> make it easy for the reviewer to cross-reference the implementation
> against what you proposed in the RFC.
>
> Best regards
> Tim Düsterhus

Hi Tim,

Thanks for helping to find a reviewer for this.  I had left the combined
PR open with the individual PRs marked as draft, but have reversed this
so the smaller PRs are ready for review.  I have also rebased and
cleaned up the commit history, added the PR numbers to the commit
history and added a link to the RFC at the top of the PR.  I think this
is everything that should be needed for this to be ready for review.

regards

Steve

Gina P. Banyard

68 days ago

On Wednesday, 3 June 2026 at 12:07, Steven Wilton <swilton@fluentit.au> wrote:

> Hi,
>
> I have gone through the RFC process for a bunch of new functionality for
> the SNMP module and wanted to check if there's anything else I need to
> do to move this forward, or if it's in the queue and waiting for the
> appropriate releases?
>

Hello Steven,

I'll have a look next week after I come back from a conference as I will need to learn about SNMP.

Best regards,

Gina P. Banyard

swilton@fluentit.au

68 days ago

On 25/06/2026 8:47 pm, Gina P. Banyard wrote:

> On Wednesday, 3 June 2026 at 12:07, Steven Wilton<swilton@fluentit.au> wrote:
>
>> Hi,
>>
>> I have gone through the RFC process for a bunch of new functionality for
>> the SNMP module and wanted to check if there's anything else I need to
>> do to move this forward, or if it's in the queue and waiting for the
>> appropriate releases?
>>
> Hello Steven,
>
> I'll have a look next week after I come back from a conference as I will need to learn about SNMP.
>
> Best regards,
>
> Gina P. Banyard

Hi Gina,

Thanks for your willingness to help get this merged. When you're ready
to look at it, I'll be very happy to help with showing what difference
the new functionality makes. I expect that 2 of the PRs should be fairly
straightforward.

regards

Steve

swilton@fluentit.au

41 days ago

On 25/06/2026 8:47 pm, Gina P. Banyard wrote:

> On Wednesday, 3 June 2026 at 12:07, Steven Wilton <swilton@fluentit.au> wrote:
>
>> Hi,
>>
>> I have gone through the RFC process for a bunch of new functionality for
>> the SNMP module and wanted to check if there's anything else I need to
>> do to move this forward, or if it's in the queue and waiting for the
>> appropriate releases?
>>
> Hello Steven,
>
> I'll have a look next week after I come back from a conference as I will need to learn about SNMP.
>
> Best regards,
>
> Gina P. Banyard

Hi Gina,

I've updated the security protocol PR based on your comment (I agree
with the suggested simplification), so that should hopefully be ready now.

I think I've fixed the formatting option PR as requested, with the
exception of the const definitions in the snmp.stub.php file. I've
extended the existing technique of using the values from the net-snmp
library, and I think it works quite well (it avoids having to map from
the PHP SNMP_* values back to the equivalent net-nsmp NETSNMP_*
values).  All code in the php-snmp module checks that a valid value has
been passed before use.  I will change this if you can see additional
benefits (I may need some guidance on the correct way to achieve this),
but I personally like the way the existing code works, and changing it
would require modifying the original php-snmp code.

Can you please have a look at the PRs for the 2 items above and let me
know if they are ready to squash and merge.  Once the above 2 are done I
can rebase the third PR and get that ready for merging.

regards

Steve