Everything

php

NetWare diff - 1.

php.internals

Ananth Kesari

22 years ago

Hi,

Please find attached, the NetWare diff (text file) in the unified
format taken using the command:  cvs diff -uN.

When I attached the diff of the whole php5 project, my mails were
bouncing. So, I have split it up manually and then sending the diff
in two mails. The first part is attached below.

Please let me know of your observations on this and if we can check
this into the php5 sources. We can shoot to have these changes
into the proposed Beta 4 for PHP5.

Thanks,
Ananth.

Andi Gutmans

22 years ago

Hi Ananth,

I'm sorry but your patches are kind of messy. There are far too many #ifdef
NETWARE's in there. It should be possible to improve on this by creating
abstraction for things such as stat.
I don't feel very comfortable with commiting them the way they are.
Has anyone else here looked at them?

Andi

At 02:03 AM 2/5/2004 -0700, Ananth Kesari wrote:

Jani Taskinen

22 years ago

Not to undermine the effort..but does anyone actually
use PHP on Netware? (or actually use netware anymore..? :)

Anyway, I agree with Andi. There has to be better way
to do this port..

--Jani


On Thu, 5 Feb 2004, Andi Gutmans wrote:

Unnamed Person

22 years ago

>
>      Not to undermine the effort..but does anyone actually
>      use PHP on Netware? (or actually use netware anymore..? :)
>

There's at least one fairly major U.S state governmental agency (whom I
happen to work for) that uses it.
You can view the mailing lists for many others, mostly enterprise:
http://forge.novell.com/modules/xfmod/project/?php

D.

Derick Rethans

22 years ago

On Thu, 5 Feb 2004, Andi Gutmans wrote:

> Hi Ananth,
>
> I'm sorry but your patches are kind of messy. There are far too many #ifdef
> NETWARE's in there. It should be possible to improve on this by creating
> abstraction for things such as stat.
> I don't feel very comfortable with commiting them the way they are.
> Has anyone else here looked at them?

I just did, and found the same conclusion. Wouldn't it be much better to
maintain an off-site patch to it?

Derick

Zeev Suraski

22 years ago

At 21:33 08/02/2004, Derick Rethans wrote:

>On Thu, 5 Feb 2004, Andi Gutmans wrote:
>
> > Hi Ananth,
> >
> > I'm sorry but your patches are kind of messy. There are far too many #ifdef
> > NETWARE's in there. It should be possible to improve on this by creating
> > abstraction for things such as stat.
> > I don't feel very comfortable with commiting them the way they are.
> > Has anyone else here looked at them?
>
>I just did, and found the same conclusion. Wouldn't it be much better to
>maintain an off-site patch to it?

I agree with Andi and think it would be best to add the necessary
abstractions to allow this patch to live in the CVS.  But I also agree that
the way it is, it's too messy to be committed...

Zeev