[PATCH] Three new GD functions

php.internals

John Coggeshall

23 years ago
I've ported three GD functions from the 2.0.12 version of GD into the bundled version: imagesetclip(), imagegetclip(), and imagecopyrotated()... I may go through and port more but I wanted to see the response to this before I wasted more time... You can find all you need at http://www.coggeshall.org/php/gd_04042003.php -~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~- John Coggeshall john at coggeshall dot org http://www.coggeshall.org/ -~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~-

Ilia A.

23 years ago
On April 4, 2003 01:11 pm, John Coggeshall wrote:
> I've ported three GD functions from the 2.0.12 version of GD into the > bundled version: imagesetclip(), imagegetclip(), and > imagecopyrotated()... I may go through and port more but I wanted to see > the response to this before I wasted more time...
I'll look into them this weekend, when I will be working on porting fixes from gd 2.0.12 into the bundled library. Ilia

Pierre-Alain Joye

23 years ago
On Fri, 4 Apr 2003 13:11:04 -0500 "John Coggeshall" <john@coggeshall.org> wrote:
> > I've ported three GD functions from the 2.0.12 version of GD into the > bundled version: imagesetclip(), imagegetclip(), and > imagecopyrotated()... I may go through and port more but I wanted to > see the response to this before I wasted more time...
I can take care of imagecopyrotated using the actual imagerotate function, which provides a better quality. Do you agree? pierre

John Coggeshall

23 years ago
I haven't done a comparison, but imagecopyrotated() isn't something I made -- I ported it from the latest version of the GD library. If you think you could make a better imagecopyrotated() I don't have a problem with it, but I don't really see a great deal of need. John -~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~- John Coggeshall john at coggeshall dot org http://www.coggeshall.org/ -~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~-

Pierre-Alain Joye

23 years ago
On Fri, 4 Apr 2003 20:30:23 -0500 "John Coggeshall" <john@coggeshall.org> wrote:
> > I haven't done a comparison, but imagecopyrotated() isn't something I > made -- I ported it from the latest version of the GD library. If you > think you could make a better imagecopyrotated() I don't have a > problem with it, but I don't really see a great deal of need.
Neither I do :) I thought it was cleaner to use the current gdImageRotate function instead of reimplement a brute force rotation function. I was afraid of bogus report like "Why copyrotate does not provide the same result as rotate?" ;-) But from my point of view, I do not care about the current GD itself, I will continue my job on php5 gd later in april, that makes more sense to us, as we discussed it sometimes ago. hth pierre