Everything

php

Cleaning up the browscap mess

php.internals

Rasmus Lerdorf

22 years ago

Guys, given the recent implosion of browscap/get_browser I would like to
find a volunteer to clean up this code.  See http://bugs.php.net/27438 for
the fireworks and http://bugs.php.net/27291 for some background.

I would suggest as a first step to pull it out of ext/standard and create
a pecl extension for it and second to go through and figure out if we can
continue to use the ini parser for this, which I am guessing we can't, so
the third task is likely to write a new parser for it.

I suppose an interim step could be to write a browscap.ini file sanitizer,
but this would be something for the volunteer(s) to decide on.

Any volunteers who feel strongly enough about this stuff to work on it?
Otherwise let's just drop it altogether.  The file this code is meant to
parse has clearly evolved and left the code behind over the years.

-Rasmus

Derick Rethans

22 years ago

On Sun, 29 Feb 2004, Rasmus Lerdorf wrote:

> I would suggest as a first step to pull it out of ext/standard and create
> a pecl extension for it and second to go through and figure out if we can
> continue to use the ini parser for this, which I am guessing we can't, so
> the third task is likely to write a new parser for it.

If you make it a pecl extension it won't be available to a lot of
people, so I think it's not a good idea to do so.

Derick

Rasmus Lerdorf

22 years ago

On Mon, 1 Mar 2004, Derick Rethans wrote:

> On Sun, 29 Feb 2004, Rasmus Lerdorf wrote:
>
> > I would suggest as a first step to pull it out of ext/standard and create
> > a pecl extension for it and second to go through and figure out if we can
> > continue to use the ini parser for this, which I am guessing we can't, so
> > the third task is likely to write a new parser for it.
>
> If you make it a pecl extension it won't be available to a lot of
> people, so I think it's not a good idea to do so.

You are not exactly helping dispell the Siberia myth here.  Making it a
maintained PECL extension has absolutely nothing to do with the number of
people it is available to.  It has everything to do with disconnecting the
release schedule from PHP's release schedule.  We would still include it
with PHP releases assuming someone actually makes it work.  Currently we
make unmaintained broken code available to a whole lot of people...

-Rasmus

Stig S. Bakken

22 years ago

On Mon, 2004-03-01 at 09:16, Derick Rethans wrote:

> On Sun, 29 Feb 2004, Rasmus Lerdorf wrote:
>
> > I would suggest as a first step to pull it out of ext/standard and create
> > a pecl extension for it and second to go through and figure out if we can
> > continue to use the ini parser for this, which I am guessing we can't, so
> > the third task is likely to write a new parser for it.
>
> If you make it a pecl extension it won't be available to a lot of
> people, so I think it's not a good idea to do so.

Here we go again :).  Isn't it better to focus energy then on making
pecl more available, than to keep stuffing the PHP Turkey?

- Stig