Everything

php

Fwd: [PHP-CVS] cvs: php-src /ext/mysqli mysqli.c

php.internals

Andi Gutmans

22 years ago

Georg,

I held RC2 because I thought this was a critical engine bug. It happened
because instead of not implementing NULL you implemented it without a body.
Right now I changed it to NULL which means that any clone either via
"clone" or compatibility_mode will result in an error message that MySQLi
is not cloneable (no crash anymore).
Should I go ahead with RC2 right now or can you fix this in the very near
future?

Andi

Adam Maccabee Trachtenberg

22 years ago

On Thu, 15 Apr 2004, Andi Gutmans wrote:

> I held RC2 because I thought this was a critical engine bug. It happened
> because instead of not implementing NULL you implemented it without a body.
> Right now I changed it to NULL which means that any clone either via
> "clone" or compatibility_mode will result in an error message that MySQLi
> is not cloneable (no crash anymore).
> Should I go ahead with RC2 right now or can you fix this in the very near
> future?

FYI: the MySQL Conference started yesterday. I don't know if Georg is
there, but it may be busy if he is.

-adam

--
adam@trachtenberg.com
author of o'reilly's php cookbook
avoid the holiday rush, buy your copy today!

Andrey Hristov

22 years ago

Adam Maccabee Trachtenberg wrote:

> On Thu, 15 Apr 2004, Andi Gutmans wrote:
>
>
>>I held RC2 because I thought this was a critical engine bug. It happened
>>because instead of not implementing NULL you implemented it without a body.
>>Right now I changed it to NULL which means that any clone either via
>>"clone" or compatibility_mode will result in an error message that MySQLi
>>is not cloneable (no crash anymore).
>>Should I go ahead with RC2 right now or can you fix this in the very near
>>future?
>
>
> FYI: the MySQL Conference started yesterday. I don't know if Georg is
> there, but it may be busy if he is.

No, he is not at the conference but is really busy. AFAIK some of the OO stuff was done by
Marcus, so maybe he can volunteer.

Andrey

Andi Gutmans

22 years ago

At 02:09 PM 4/15/2004 -0400, Adam Maccabee Trachtenberg wrote:

>On Thu, 15 Apr 2004, Andi Gutmans wrote:
>
> > I held RC2 because I thought this was a critical engine bug. It happened
> > because instead of not implementing NULL you implemented it without a body.
> > Right now I changed it to NULL which means that any clone either via
> > "clone" or compatibility_mode will result in an error message that MySQLi
> > is not cloneable (no crash anymore).
> > Should I go ahead with RC2 right now or can you fix this in the very near
> > future?
>
>FYI: the MySQL Conference started yesterday. I don't know if Georg is
>there, but it may be busy if he is.

Personally, I think we can roll RC2 with the way the tree is now. The fact
that MySQLi isn't cloneable isn't a big deal because:
a) It's a new PHP 5 feature which is most likely not run in
zend.zend1_compatibility_mode
b) If explicit "clone" isn't supported, that's fine. An extension doesn't
have to be cloneable.

Andi

Adam Maccabee Trachtenberg

22 years ago

On Thu, 15 Apr 2004, Andi Gutmans wrote:

> Personally, I think we can roll RC2 with the way the tree is now. The fact
> that MySQLi isn't cloneable isn't a big deal because:
> a) It's a new PHP 5 feature which is most likely not run in
> zend.zend1_compatibility_mode
> b) If explicit "clone" isn't supported, that's fine. An extension doesn't
> have to be cloneable.

c) MySQL 4.1 is still alpha, so nobody should be relying on it for
production use anyway.

-adam

--
adam@trachtenberg.com
author of o'reilly's php cookbook
avoid the holiday rush, buy your copy today!