Everything

php

count() doesn't work on overloaded objects

php.internals

Wez Furlong

22 years ago

While solving http://bugs.php.net/bug.php?id=27974,
we've discovered that count() on an overloaded object
(in this case, a variant object representing an OLE
SafeArray) doesn't return a truthful value.

What, if anything, are we going to do about that?

We could add a hook to the C iterator API for count();
it shouldn't have a huge impact on the rest of the engine.

--Wez.

Andi Gutmans

22 years ago

At 02:24 PM 4/23/2004 +0100, Wez Furlong wrote:

>While solving http://bugs.php.net/bug.php?id=27974,
>we've discovered that count() on an overloaded object
>(in this case, a variant object representing an OLE
>SafeArray) doesn't return a truthful value.
>
>What, if anything, are we going to do about that?
>
>We could add a hook to the C iterator API for count();
>it shouldn't have a huge impact on the rest of the engine.

I'm not sure if the Iterators API is the right place (it's an API for
foreach()). I guess it could be in either the Iterators API or the Object
API. What would you expect it to return as far as PPP properties is concerned?

By the way, I was holding off RC2 because of that bug you found. Any news?
Can I roll RC2?

Andi

Wez Furlong

22 years ago

> >We could add a hook to the C iterator API for count();
> >it shouldn't have a huge impact on the rest of the engine.
>
> I'm not sure if the Iterators API is the right place (it's an API for
> foreach()). I guess it could be in either the Iterators API or the Object
> API. What would you expect it to return as far as PPP properties is

concerned?

True.  How about making it an optional handler along with the regular
handlers for the overloaded object; if it is not present, stick with
the current behaviour, otherwise, use the return value of that handler.

> By the way, I was holding off RC2 because of that bug you found. Any news?
> Can I roll RC2?

I didn't get a chance to dig in yet, and I have a bit to wrap up
before I can take a look at it this weekend.

It would be nice to fix before RC2, but since I haven't really
pinned down the precise cause, it's up to you :)

--Wez.

Andi Gutmans

22 years ago

Okay. I'll release RC2 without it. There have been too many important
fixes, and this seems to be an old bug.
Keep me posted when you manage to nail things down. I'll talk to Zeev about
count() and see what he thinks.

Andi

At 03:32 PM 4/23/2004 +0100, Wez Furlong wrote:

George Schlossnagle

22 years ago

On Apr 23, 2004, at 9:24 AM, Wez Furlong wrote:

> While solving http://bugs.php.net/bug.php?id=27974,
> we've discovered that count() on an overloaded object
> (in this case, a variant object representing an OLE
> SafeArray) doesn't return a truthful value.
>
> What, if anything, are we going to do about that?
>
> We could add a hook to the C iterator API for count();
> it shouldn't have a huge impact on the rest of the engine.

I talked about this with Marcus a few months ago.  I think that objects
which implement the necessary interfaces should work as arrays in all
the standard array functions.  Marcus had an old patch for this that I
would be happy to help update if people are keen on this idea.

George