Could anybody comment this patch, please ?
On Tue, 18 May 2004 17:09:42 +0400
Antony Dovgal <tony2001@phpclub.net> wrote:
> On Tue, 18 May 2004 13:55:18 +0100
> "Wez Furlong" <wez@thebrainroom.com> wrote:
>
> > Hey Antony,
> >
> > This is most likely due to some issues with serialize/unserialize and floating
> > point numbers; we don't want the format to change with the locale, since it
> > should be independent.
> >
> > Yes, it is a mess :)
>
> ok.
> but in this case we can set all except LC_NUMERIC and it should not affect floats.
> so, the patch should look like this:
>
> Index: main.c
> ===================================================================
> RCS file: /repository/php-src/main/main.c,v
> retrieving revision 1.601
> diff -u -r1.601 main.c
> --- main.c 24 Mar 2004 13:33:26 -0000 1.601
> +++ main.c 18 May 2004 13:08:18 -0000
> @@ -1365,7 +1365,12 @@
> PG(disable_classes) = NULL;
>
> #if HAVE_SETLOCALE
> + setlocale(LC_COLLATE, "");
> setlocale(LC_CTYPE, "");
> + setlocale(LC_MESSAGES, "");
> + setlocale(LC_MONETARY, "");
> + setlocale(LC_TIME, "");
> + /* LC_NUMERIC is not set due to some issues with serialize/unserialize */
> #endif
>
> #if HAVE_TZSET
---
WBR,
Antony Dovgal aka tony2001
tony2001@phpclub.net || antony@dovgal.com
