Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » Mem Leak in Tidy, ZE2 Bug? »

Mem Leak in Tidy, ZE2 Bug?

php.internals

Christian Stocker

22 years ago
Hi I'm not sure, who to blame about this one, but I run against a memory leak if I run the following code: *** $html = "foo"; $options = array("char-encoding" => "utf8"); $tidy = new tidy(); $tidy->parseString($html,$options,$options['char-encoding']); print $tidy; *** If the 3rd param is not part of the array of the second param, there's no memleak.. Any ideas, what's going wrong here? If it's tidy, I'll file a bug report, if it's ZE2, it's maybe something to be fixed before 5.0.0 ;) chregu
-- christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB

Nuno Lopes

22 years ago
> Hi > > I'm not sure, who to blame about this one, but I run against a memory > leak if I run the following code: > *** > $html = "foo"; > $options = array("char-encoding" => "utf8"); > $tidy = new tidy(); > $tidy->parseString($html,$options,$options['char-encoding']); > print $tidy; > *** > > If the 3rd param is not part of the array of the second param, there's > no memleak.. > Any ideas, what's going wrong here?
I have no problems here. You shouldn't use the char-encoding as option (the second paramether)!! You should just set the last parameter, as it will set the input and ouput charset!! there is also a open bug for tidy: http://bugs.php.net/?id=28578

Derick Rethans

22 years ago
On Tue, 8 Jun 2004, Nuno Lopes wrote:
> You shouldn't use the char-encoding as option (the second paramether)!! You > should just set the last parameter, as it will set the input and ouput > charset!!
No need for those extra exclamation marks, and even *if* he used the function wrongly it shouldn't leak memory. Derick

Christian Stocker

22 years ago
On 8.6.2004 12:42 Uhr, Nuno Lopes wrote:
>>Hi >> >>I'm not sure, who to blame about this one, but I run against a memory >>leak if I run the following code: >>*** >>$html = "foo"; >>$options = array("char-encoding" => "utf8"); >>$tidy = new tidy(); >>$tidy->parseString($html,$options,$options['char-encoding']); >>print $tidy; >>*** >> >>If the 3rd param is not part of the array of the second param, there's >>no memleak.. >>Any ideas, what's going wrong here? > > > I have no problems here. > You shouldn't use the char-encoding as option (the second paramether)!! You > should just set the last parameter, as it will set the input and ouput > charset!!
See Derick's answer, that's not the point ;) Anyway, I filed a bug report for tidy (there was also a second memleak) at http://pecl.php.net/bugs/bug.php?id=1580 chregu
-- christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB

John Coggeshall

22 years ago
I'll poke around at it today John On Tue, 2004-06-08 at 07:58, Christian Stocker wrote:
> On 8.6.2004 12:42 Uhr, Nuno Lopes wrote: > > >>Hi > >> > >>I'm not sure, who to blame about this one, but I run against a memory > >>leak if I run the following code: > >>*** > >>$html = "foo"; > >>$options = array("char-encoding" => "utf8"); > >>$tidy = new tidy(); > >>$tidy->parseString($html,$options,$options['char-encoding']); > >>print $tidy; > >>*** > >> > >>If the 3rd param is not part of the array of the second param, there's > >>no memleak.. > >>Any ideas, what's going wrong here? > > > > > > I have no problems here. > > You shouldn't use the char-encoding as option (the second paramether)!! You > > should just set the last parameter, as it will set the input and ouput > > charset!! > > See Derick's answer, that's not the point ;) > > Anyway, I filed a bug report for tidy (there was also a second memleak) at > http://pecl.php.net/bugs/bug.php?id=1580 > > chregu > -- > christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich > phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 > http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB
-- -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=- John Coggeshall http://www.coggeshall.org/ The PHP Developer's Handbook http://www.php-handbook.com/ -=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=--=~=-

Ilia A.

22 years ago
The leak had been fixed. Ilia