Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [PATCH] tidylib behaviour changed »

[PATCH] tidylib behaviour changed

php.internals

Nuno Lopes

22 years ago
Hi, Finally today, the tidy team has corrected a bug in tidyLoadConfig. Attached is a patch that fixes PHP for the new behaviour (which is backward compatible with older libs) and I've also removed the repairString() and repairFile() methods (see why in my previous e-mail). Regards, Nuno -------------------------------------------------- Tidy bug: http://sourceforge.net/tracker/?func=detail&atid=390963&aid=937271&group_id=27659 Tidy response: "I have changed your patch, so that the tidyLoadConfig() return value is consistent with the existing usage of tidyLoadConfig() - e.g. in "tidy.c": -1 if the file is not found 0 if the file was parsed correctly 1 if there were errors parsing the file (unknown option, etc...) i.e. no change to the last line of the function." --------------------------------------------------

Steph

22 years ago
Those methods work fine. The code's incorrect in your example; you were echoing the original string.
> -----Original Message----- > From: Nuno Lopes [mailto:nlopess@php.net] > Sent: 05 July 2004 10:48 > To: PHPdev > Subject: [PHP-DEV] [PATCH] tidylib behaviour changed > > > Hi, > > Finally today, the tidy team has corrected a bug in > tidyLoadConfig. Attached > is a patch that fixes PHP for the new behaviour (which is backward > compatible with older libs) and I've also removed the repairString() and > repairFile() methods (see why in my previous e-mail). > > Regards, > Nuno > > > > -------------------------------------------------- > Tidy bug: > http://sourceforge.net/tracker/?func=detail&atid=390963&aid=937271
&group_id=27659 Tidy response: "I have changed your patch, so that the tidyLoadConfig() return value is consistent with the existing usage of tidyLoadConfig() - e.g. in "tidy.c": -1 if the file is not found 0 if the file was parsed correctly 1 if there were errors parsing the file (unknown option, etc...) i.e. no change to the last line of the function." --------------------------------------------------

Nuno Lopes

22 years ago
Hi Steph!
> Those methods work fine. The code's incorrect in your example; you were > echoing the original string.
Can you explain me how? :) When I was writing the docs I couldn't work with them.... But IHMO they should be removed or made static. But this patch must be applied because of the behaviour change for tidyLoadConfig. Nuno

Derick Rethans

22 years ago
On Mon, 5 Jul 2004, Nuno Lopes wrote:
> Hi Steph! > > > Those methods work fine. The code's incorrect in your example; you were > > echoing the original string. > > Can you explain me how? :) When I was writing the docs I couldn't work with > them.... But IHMO they should be removed or made static. > But this patch must be applied because of the behaviour change for > tidyLoadConfig.
Let the maintainer (John) handle that. Derick