Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [PATCH] tests/classes/factory_and_singleton_010.phpt »

[PATCH] tests/classes/factory_and_singleton_010.phpt

php.internals

Kamesh Jayachandran

22 years ago
Hi All, I had the tests/classes/factory_and_singleton_010.phpt testcase failing in Linux, NetWare, Windows ports of PHP. And found that this failure is due to one extra line. Attached the patch. With regards Kamesh Jayachandran

Marcus Börger

22 years ago
Hello Kamesh, can you adapt you test files to ouput a single line before the actual script starts by using 'echo "*\n";' for example and see if you get a blank line in the output then? I checked all testfiles again and they all PASS for me pretty fine. And in all the qa reports we got so far there was never such a problem as you mentioned. regards marcus Thursday, July 22, 2004, 9:25:19 AM, you wrote:
> Hi All, > I had the tests/classes/factory_and_singleton_010.phpt testcase failing > in Linux, NetWare, Windows ports of PHP. > And found that this failure is due to one extra line.
> Attached the patch.
> With regards > Kamesh Jayachandran
-- Best regards, Marcus mailto:helly@php.net

Kamesh Jayachandran

22 years ago
Hello Marcus, On Thu, 22 Jul 2004 20:47:31 +0200, "Marcus Boerger" <helly@php.net> said:
> Hello Kamesh, > > can you adapt you test files to ouput a single line before the actual > script starts by using 'echo "*\n";' for example and see if you get > a blank line in the output then? >
I did not get what you mean by this. Do you want me to go to each test case and add echo '\n'; as the first executable statement? How it will help? With regards Kamesh Jayachandran

Marcus Börger

22 years ago
Hello Kamesh, Saturday, July 24, 2004, 6:10:56 PM, you wrote:
> Hello Marcus, > On Thu, 22 Jul 2004 20:47:31 +0200, "Marcus Boerger" <helly@php.net> > said: >> Hello Kamesh, >> >> can you adapt you test files to ouput a single line before the actual >> script starts by using 'echo "*\n";' for example and see if you get >> a blank line in the output then? >> > I did not get what you mean by this. > Do you want me to go to each test case and add echo '\n'; as the first > executable statement?
yes but echo "*\n" would be easier to track
> How it will help?
It won't help i simply want to see what you get then. regards marcus

Kamesh Jayachandran

22 years ago
Hello Marcus, I am attaching my test log file after adding echo "*\n"; as the first executable statment. With regards Kamesh Jayachandran On Sun, 25 Jul 2004 08:21:38 +0200, "Marcus Boerger" <helly@php.net> said: