php.net announcement

php.internals

Sterling Hughes

22 years ago
http://www.php.net/: Hereby we would like to kindly ask everyone who published an article or howto about installing PHP on Windows to revise those instructions according to our latest guide. These new instructions got distributed with PHP 5.0.1 in both the source code and binary versions, and will continue to be shipped with future versions of PHP. Uhm, Its nice that there are new instructions and all, but should we really be recommending this? What's the reason for this announcement? -Sterling

Sean Coates

22 years ago
This news posting also says "more easier", and should not. I don't have the necessary karma to correct this. S Sterling Hughes wrote:

Zeev Suraski

22 years ago
It's fixed, and I also removed this 'call for change' paragraph. It's unreasonable to ask everyone who ever published an article or a HOWTO to update their stuff, any more than it makes sense to ask everyone who ever wrote an XML article to update it for SimpleXML. It has to happen naturally... Zeev At 07:33 18/08/2004, Sean Coates wrote:

Gordon P. Hemsley

22 years ago
If I remember correctly, the reason that the "call for change" was included was because the new installation instructions described a different method of installation than the old installation instructions. The "call for change" was for everyone who had previously written an article or tutorial on how to install PHP itself, so as to try to keep installation methods the same; changing an article about XML for SimpleXML is not the same thing. On Wed, 18 Aug 2004 15:26:24 +0300, Zeev Suraski <zeev@zend.com> wrote:
> It's fixed, and I also removed this 'call for change' paragraph. It's > unreasonable to ask everyone who ever published an article or a HOWTO to > update their stuff, any more than it makes sense to ask everyone who ever > wrote an XML article to update it for SimpleXML. It has to happen naturally... > > Zeev > > > > At 07:33 18/08/2004, Sean Coates wrote: > >This news posting also says "more easier", and should not. I don't have > >the necessary karma to correct this. > > > >S > > > >Sterling Hughes wrote: > >>http://www.php.net/: > >> Hereby we would like to kindly ask everyone who published an article > >>or howto about installing PHP on Windows to revise those instructions > >>according to our latest guide. These new instructions got distributed > >>with PHP 5.0.1 in both the source code and binary versions, and will > >>continue to be shipped with future versions of PHP. > >>Uhm, Its nice that there are new instructions and all, but should we > >>really be recommending this? What's the reason for this announcement? > >>-Sterling > > > >-- > >PHP Internals - PHP Runtime Development Mailing List > >To unsubscribe, visit: http://www.php.net/unsub.php > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
-- Gordon P. Hemsley gphemsley@gmail.com http://www.lttp.net/ • http://cmsforme.sourceforge.net/

Unnamed Person

22 years ago
sorry in advance for the length, formatting and possible redundancy of this message. Anyway, on Windows, leaving "sendmail_from" blank and setting a "From:" header in the extra headers parameter doesn't work. test.php: <?php mail('example@php.com','subject','body',"From: me@example.com\r\n"); /* Warning: mail(): "sendmail_from" not set in php.ini or custom "From:" header missing in C:\dev\quiktests\test.php on line 3 */ ??--> http://bugs.php.net/bug.php?id=28976 there are also a couple user notes on the mail manual page to the effect of "use ini_set()", but that seems messy, especially for distributed scripts to do a check everytime they send mail(): if(PHP_OS == 'Win' && empty(ini_get("sendmail_from")){ ini_set("sendmail_from", $tempFromAddress); } I don't know C (or any cvs/patch tools), but here's what I think is going on: in ext/standard/mail.c we find the following code (notice the last argument to TSendMail() is NULL): [code] .... PHPAPI int php_mail(char *to, char *subject, char *message, char *headers, char *extra_cmd TSRMLS_DC) { ..... if (!sendmail_path) { #if (defined PHP_WIN32 || defined NETWARE) /* handle old style win smtp sending */ if (TSendMail(INI_STR("SMTP"), &tsm_err, &tsm_errmsg, headers, subject, to, message, NULL, NULL, NULL) == FAILURE) { .... [/code] unfortunately, in win32/sendmail.c we find this: [code] .... PHPAPI int TSendMail(char *host, int *error, char **error_message, char *headers, char *Subject, char *mailTo, char *data, char *mailCc, char *mailBcc, char *mailRPath) { .... /* Fall back to sendmail_from php.ini setting */ if (mailRPath && *mailRPath) { RPath = estrdup(mailRPath); } else if (INI_STR("sendmail_from")) { RPath = estrdup(INI_STR("sendmail_from")); } else { if (headers) { efree(headers); efree(headers_lc); } *error = W32_SM_SENDMAIL_FROM_NOT_SET; return FAILURE; } .... [/code] it seems mailRPath will always be NULL and "sendmail_from" will always be "fallen back" to, and thus you get an error. maybe, probably, i'm missing something, but at the very least, the error message ("custom "From:" header missing") or the documentation could be altered. thanks.

Zeev Suraski

22 years ago
At 01:02 19/08/2004, Gordon P. Hemsley wrote:
>If I remember correctly, the reason that the "call for change" was >included was because the new installation instructions described a >different method of installation than the old installation >instructions. > >The "call for change" was for everyone who had previously written an >article or tutorial on how to install PHP itself, so as to try to keep >installation methods the same; changing an article about XML for >SimpleXML is not the same thing.
It's very much the same in my opinion, just s/installation methods/XML programming methods/g. Zeev