Everything

php

Home » Project » Newsgroups » php.internals » [PATCH] zend_compile.c warning fix »

[PATCH] zend_compile.c warning fix

php.internals

Joe Orton

22 years ago

If casting pointers to integers at least cast to a long, to avoid
compiler warnings:

--- Zend/zend_compile.c	23 Aug 2004 20:58:48 -0000	1.581
+++ Zend/zend_compile.c	24 Aug 2004 14:50:31 -0000
@@ -68,7 +68,7 @@
uint char_pos_len;
char *filename;

-	char_pos_len = zend_sprintf(char_pos_buf, "%x", (unsigned int) LANG_SCNG(_yy_last_accepting_cpos));
+	char_pos_len = zend_sprintf(char_pos_buf, "%lx", (unsigned long) LANG_SCNG(_yy_last_accepting_cpos));
if (CG(active_op_array)->filename) {
filename = CG(active_op_array)->filename;
} else {

Ilia A.

22 years ago

What compiler flags are you using that you see this warning message? I do not
see on the local build here.

Ilia

On August 24, 2004 10:53 am, Joe Orton wrote:

Joe Orton

22 years ago

On Tue, Aug 24, 2004 at 08:53:15PM -0400, Ilia Alshanetsky wrote:

> What compiler flags are you using that you see this warning message? I do not
> see on the local build here.

gcc -Wall warns, any LP64 platform.

Zend/zend_compile.c: In function `build_runtime_defined_function_key':
Zend/zend_compile.c:71: warning: cast from pointer to integer of different size

Andi Gutmans

22 years ago

Probably 64bit system?

At 08:53 PM 8/24/2004 -0400, Ilia Alshanetsky wrote: