Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [PATCH] ok this works in all cases and smells right »

[PATCH] ok this works in all cases and smells right

php.internals

Steph

21 years ago
BTW shouldn't main/config.w32.h be in .cvsignore? - Steph

Wez Furlong

21 years ago
On Mon, 13 Sep 2004 18:55:14 +0100, Steph <steph@zend.com> wrote:
> BTW shouldn't main/config.w32.h be in .cvsignore?
Ideally, yes, but it's still used as-is by the .dsp build system Your patch looks much better (note that the # character for #define's and #ifdefs etc. should start in the left-most column, otherwise some weirdo compilers will break). --Wez.

Derick Rethans

21 years ago
On Mon, 13 Sep 2004, Steph wrote:
> BTW shouldn't main/config.w32.h be in .cvsignore?
This patch is wrong, the #if HAVE_STRCOLL should be there in all places, also, I did not guard the constant registration as that can always be available just fine. Derick
-- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org