[PATCH] Zend_API.c error message tweak

php.internals

Joe Orton

21 years ago
HEAD/ext/spl is generating a warning at startup though it was hard to work out which extension was to blame without the below patch! PHP Warning: Function registration failed - duplicate name - InfiniteIterator::next in Unknown on line 0 Index: Zend/zend_API.c =================================================================== RCS file: /repository/ZendEngine2/zend_API.c,v retrieving revision 1.268 diff -u -r1.268 zend_API.c --- Zend/zend_API.c 29 Sep 2004 20:57:07 -0000 1.268 +++ Zend/zend_API.c 2 Nov 2004 12:42:41 -0000 @@ -1397,7 +1397,8 @@ } while (ptr->fname) { if (zend_hash_exists(target_function_table, ptr->fname, strlen(ptr->fname)+1)) { - zend_error(error_type, "Function registration failed - duplicate name - %s", ptr->fname); + zend_error(error_type, "Function registration failed - duplicate name - %s%s%s", + scope ? scope->name : "", scope ? "::" : "", ptr->fname); } ptr++; }

Derick Rethans

21 years ago
On Tue, 2 Nov 2004, Joe Orton wrote:
> HEAD/ext/spl is generating a warning at startup though it was hard to > work out which extension was to blame without the below patch! > > PHP Warning: Function registration failed - duplicate name - > InfiniteIterator::next in Unknown on line 0
I'd say feel free to commit this, if you also adjust the test cases that might now fail due to the changed error messages. regards, Derick
-- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org

Joe Orton

21 years ago
On Tue, Nov 02, 2004 at 01:56:03PM +0100, Derick Rethans wrote:
> On Tue, 2 Nov 2004, Joe Orton wrote: > > > HEAD/ext/spl is generating a warning at startup though it was hard to > > work out which extension was to blame without the below patch! > > > > PHP Warning: Function registration failed - duplicate name - > > InfiniteIterator::next in Unknown on line 0 > > I'd say feel free to commit this, if you also adjust the test cases that > might now fail due to the changed error messages.
I don't have commit access to Zend - and I can't find any test cases which check for this error text. The test suite is failing all over the shop anyway because this error is printed on every invocation. joe

Sebastian Bergmann

21 years ago
Joe Orton wrote:
> I don't have commit access to Zend
I tested and committed it, will MFH to PHP_5_0 in a second.
-- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69