Everything

php

RE: more ftp functions

php.internals

Binam, Jesse

21 years ago

Let me rephrase that. This is my first contribution to php or any open
source project for that matter, and I have no idea what the process is.
Do I need to write the code first and submit a patch to someone? Do I
need to work with someone since I assume don't have CVS write access? Is
the process in the comments or documented somewhere and I am going to
get flamed for not reading them? ;)

Thanks,
Jess

________________________________

From: Binam, Jesse [mailto:Jesse.Binam@simplot.com]
Sent: Thursday, December 02, 2004 11:30 AM
To: internals@lists.php.net
Subject: [PHP-DEV] more ftp functions


I apologize if I am posting this to the wrong list I am a newbie to the
lists.

I would like to add some functions to the ftp extention. Most notably at
this point I am interested in a ftp_get_resp() that returns ftp->inbuf
and perhaps the response code from the server. Or maybe it could return
the whole conversation. A (very) basic example of what I am aiming for
is below. How should I proceed?

Thanks,
Jess

<?php

$conn = ftp_connect('ftp.somewhere.com');
$ok = ftp_login($conn,'user','pass');
if(!$ok){ echo ftp_get_resp($conn); }
$ok = ftp_put();
if(!$ok){ echo ftp_get_resp($conn); }

?>

Adam Maccabee Trachtenberg

21 years ago

On Thu, 2 Dec 2004, Binam, Jesse wrote:

> Let me rephrase that. This is my first contribution to php or any open
> source project for that matter, and I have no idea what the process is.
> Do I need to write the code first and submit a patch to someone? Do I
> need to work with someone since I assume don't have CVS write access? Is
> the process in the comments or documented somewhere and I am going to
> get flamed for not reading them? ;)

I would suggest you create a patch and post it to the mailing list. If
it's accepted, someone will commit it for you.

Regardless of what you do, I can't predict whether you will or will
not get flamed. :)

-adam

--
adam@trachtenberg.com | http://www.trachtenberg.com
author of o'reilly's "upgrading to php 5" and "php cookbook"
avoid the holiday rush, buy your copies today!

Wez Furlong

21 years ago

There's a README.SUBMITTING-PATCH file in the PHP source that gives a
fair amount detail on the preferred way to contribute to the project.

It boils down to submitting a patch (unified diff) against HEAD of CVS
to the internals list and CC'ing it to the appropriate extension
maintainer(s) (there is an EXTENSIONS file that should be more or less
up to date with who is looking after what).

Welcome :)

--Wez.


On Thu, 2 Dec 2004 23:50:10 -0700, Binam, Jesse <jesse.binam@simplot.com> wrote:

Andi Gutmans

21 years ago

You can lower the changes by supplying a unified diff :)

Andi

At 11:35 AM 12/3/2004 -0500, Adam Maccabee Trachtenberg wrote: