Not sure about removing the comment from the bug report as someone might need it as a clue, surely it would have been better to just addd your comment and leave mine intact.
Jani, are you going to post a real patch? I'm not a C programmer (life's too short etc) - I'd probably get it wrong again.
John.
-----Original Message-----
From: Jani Taskinen [mailto:sniper@iki.fi]
Sent: 24 January 2005 04:44
To: Carter, John
Cc: internals@lists.php.net
Subject: Re: [PHP-DEV] Patch for bug 29334 Daylight Savings Win32
This "fix" is not very ideal considering this note about tm_isdst property:
"Positive value if daylight saving time is in effect; 0 if daylight
saving time is not in effect; negative value if status of daylight
saving time is unknown. If the TZ environment variable is set, the C
run-time library assumes rules appropriate to the United States for
implementing the calculation of daylight-saving time (DST)."
In case the status of dst is unknown, you'd be removing 1 or more
hours from the time..
--Jani
p.s. I removed this patch from the bug report.
On Fri, 14 Jan 2005, Carter, John wrote:
