Everything

php

XML Bug #32001

php.internals

Marcus Boerger

21 years ago

Hello moriyoshi or any other XMLer,

please verify the --EXPECT-- data in test ext/xml/tests/bug32001.phpt
i am quite sure there are several mistakes in it.

--
Best regards,
Marcus                          mailto:mail@marcus-boerger.de

Moriyoshi Koizumi

21 years ago

On 2005/03/11, at 10:24, Marcus Boerger wrote:

> Hello moriyoshi or any other XMLer,
>
>   please verify the --EXPECT-- data in test ext/xml/tests/bug32001.phpt
> i am quite sure there are several mistakes in it.

Excuse me if I'm just missing something, what kind of mistake do
you want to address?

Moriyoshi

Marcus Boerger

21 years ago

Hello Moriyoshi,

Friday, March 11, 2005, 4:44:19 AM, you wrote:

> On 2005/03/11, at 10:24, Marcus Boerger wrote:

>> Hello moriyoshi or any other XMLer,
>>
>>   please verify the --EXPECT-- data in test ext/xml/tests/bug32001.phpt
>> i am quite sure there are several mistakes in it.

> Excuse me if I'm just missing something, what kind of mistake do
> you want to address?

Somehow i have the feeling that most of the expected results are wrong
by simply looking at file in hex format. So it would be nice if someone
could confirm or decline that.

--
Best regards,
Marcus                            mailto:mail@marcus-boerger.de

Rob Richards

21 years ago

The test works fine for me under linux. Only difference is on windows
and there its to how windows performs php_strtoupper differently. If
case folding is turned off under windows, the test passes.

Rob

Moriyoshi Koizumi wrote:

Moriyoshi Koizumi

21 years ago

On 2005/03/11, at 20:38, Rob Richards wrote:

> The test works fine for me under linux. Only difference is on windows
> and there its to how windows performs php_strtoupper differently. If
> case folding is turned off under windows, the test passes.

It looks like the problem is due to the following facts.

- php_strtoupper() depends on the locale settings.
- toupper() works differently between platforms. Besides it isn't
designed to handle multibyte strings like UTF-8.

I was mostly testing on Linux so I couldn't replicate it
(now verified on Mac OS X).

I think case folding option doesn't make any sense if it doesn't
work perfectly and we better deprecate it until some unicode-aware
case folding function is available.

Moriyoshi