Everything

php

#if ZEND_ALLOC 0 patch

php.internals

Derick Rethans

21 years ago

Hello Andi,

the following patch fixes issues when ZEND_ALLOC is set to 0 (to be able
to debug memory related issues in / with the engine):

http://files.derickrethans.nl/patches/zend-alloc-strndup-20050407.patch

This is because estrdup needs to allocate one more byte than the length
and you can't do that differently with strdup. I'd like to commit this
patch to all branches.

regards,
Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

Zeev Suraski

21 years ago

@@ -80,7 +80,7 @@ ZEND_API void *_erealloc(void *ptr, size
ZEND_API char *_estrdup(const char *s ZEND_FILE_LINE_DC
ZEND_FILE_LINE_ORIG_DC) ZEND_ATTRIBUTE_MALLOC;
ZEND_API char *_estrndup(const char *s, unsigned int length
ZEND_FILE_LINE_DC ZEND_FILE_LINE_ORIG_DC) ZEND_ATTRIBUTE_MALLOC;

-#define USE_ZEND_ALLOC 1
+#define USE_ZEND_ALLOC 0

Nice try ;)

Committed, thanks.

Zeev

At 16:42 07/04/2005, Derick Rethans wrote:

Derick Rethans

21 years ago

On Thu, 7 Apr 2005, Zeev Suraski wrote:

> @@ -80,7 +80,7 @@ ZEND_API void *_erealloc(void *ptr, size
>  ZEND_API char *_estrdup(const char *s ZEND_FILE_LINE_DC
> ZEND_FILE_LINE_ORIG_DC) ZEND_ATTRIBUTE_MALLOC;
>  ZEND_API char *_estrndup(const char *s, unsigned int length ZEND_FILE_LINE_DC
> ZEND_FILE_LINE_ORIG_DC) ZEND_ATTRIBUTE_MALLOC;
>
> -#define USE_ZEND_ALLOC 1
> +#define USE_ZEND_ALLOC 0
>
> Nice try ;)

That was an accident... I guess I can commit it to PHP 5.0 and 5.1 too?

regards,
Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org