Everything

php

IS_TYPE in zend_compile.c

php.internals

John Coggeshall

23 years ago

About 16 hours ago it looks like someone modified zend_compile.c to fix
a bug... the current head has around line 1161 (clean CVS checkout):

if (type_hint->op_type == IS_TYPE) {
opline->opcode = ZEND_VERIFY_TYPE;
} else {
opline->opcode = ZEND_VERIFY_INSTANCEOF;
}

But now i can't seem to compile it anymore... where is IS_TYPE defined?
I'm assuming if it exists at all, it has to have been in the engine for
awhile looking at the commit times (zend_compile.c is the only file
modified in the past 16 hours)... either way, neither myself or the
compiler can find it.

Perhaps there is just something broken about my system... but I thought
I'd make sure before I went on a goose chase.

John

--
-~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~-
John Coggeshall
john at coggeshall.org                      http://www.coggeshall.org/
-~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~--~=~-

Jan Schneider

23 years ago

John Coggeshall wrote:

> About 16 hours ago it looks like someone modified zend_compile.c to fix
> a bug... the current head has around line 1161 (clean CVS checkout):
>
> if (type_hint->op_type == IS_TYPE) {
> 	opline->opcode = ZEND_VERIFY_TYPE;
> } else {
> 	opline->opcode = ZEND_VERIFY_INSTANCEOF;
> }
>
> But now i can't seem to compile it anymore... where is IS_TYPE defined?
> I'm assuming if it exists at all, it has to have been in the engine for
> awhile looking at the commit times (zend_compile.c is the only file
> modified in the past 16 hours)... either way, neither myself or the
> compiler can find it.
>
> Perhaps there is just something broken about my system... but I thought
> I'd make sure before I went on a goose chase.

No, I can confirm this. Updated a minute ago.

Jan.

Moriyoshi Koizumi

23 years ago

Marcus apparently left to the conference with the build broken.

My workaround:
$ cvs diff -r 1.414 Zend/zend_compile.c | patch -p0 -R

Moriyoshi

John Coggeshall <john@coggeshall.org> wrote:

Edin Kadribasic

23 years ago

On Thu, 8 May 2003, Moriyoshi Koizumi wrote:

> Marcus apparently left to the conference with the build broken.
>
> My workaround:
> $ cvs diff -r 1.414 Zend/zend_compile.c | patch -p0 -R

I reverted his patch so cvs head should be building again. Hopefully
Marcus can commit a complete patch once he gets back from Amsterdam :)

Edin