Everything
php
Learn Community Releases The PHP Project
Home » Project » Newsgroups » php.internals » [PATCH] bugfix for #29983 (unable to set default_charset using ini_set) »

[PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

php.internals

Antony Dovgal

21 years ago
Hello all, hello Andi. Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983 It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in runtime) to substitute SAPI content-type/charset header. See the patch in attachment.
-- Wbr, Antony Dovgal

Antony Dovgal

21 years ago
On Thu, 23 Jun 2005 01:28:04 +0400 Antony Dovgal <antony@zend.com> wrote:
> Hello all, hello Andi. > > Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983 > It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in runtime) to substitute SAPI content-type/charset header. > See the patch in attachment.
Btw, the same issue applies to default_mimetype too, so I'll cook another one patch (it won't take a lot of time) if this one is ok.
-- Wbr, Antony Dovgal

Ilia A.

21 years ago
Tony, It looks like you are missing a check to determine if the headers have already been sent. Ilia

Andi Gutmans

21 years ago
I suggest to leave this out of Beta 2 and I'd like to hear feedback from others here as to this patch. Andi At 01:28 AM 6/23/2005 +0400, Antony Dovgal wrote: