Everything

php

HAVE_INT32_T check in ext/date/lib/timelib_structs.h(php 5.1)

php.internals

Kamesh Jayachandran

21 years ago

Hi Derick,
Who will define HAVE_INT32_T?
I could see ./configure detects it and defines it in main/php_config.h.
But How ext/date/lib/timelib_structs.h know about this?
I could not see ext/date/lib/timelib_structs.h including
main/php_config.h.
#ifndef HAVE_INT32_T
# if SIZEOF_INT == 4
typedef int int32_t;
# elif SIZEOF_LONG == 4
typedef long int int32_t;
# endif
#endif

My NetWare build is breaking because stdio.h which is included after the
above code block also tries to define int32_t which causes a compilation
error.

#include <php_config.h> this at the start of the file(ofcourse after the
guard) solves the problem.

P.S in Zend/zend_strtod.c also we have similar code(checking for
HAVE_INT32_T) there it works because we include
zend_strtod.h->zend.h>zend_config.h->mail/php_config.h), here we don't
have anything of that sort.

Please do the needful.
With regards
Kamesh Jayachandran

--
http://www.fastmail.fm - A fast, anti-spam email service.

Derick Rethans

21 years ago

On Wed, 29 Jun 2005, Kamesh Jayachandran wrote:

> #include <php_config.h> this at the start of the file(ofcourse after the
> guard) solves the problem.

Should be fixed in CVS, please test.

regards,
Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

Kamesh Jayachandran

21 years ago

Thanks Derick.
Still have one small issue with it for NetWare.
We decided to use autoconf based build for PHP-5.1 so we don't want to
use config.nw.h(Soon will delete it from the source tree)
This patch takes cares of it.
http://www.ductape.net/~kameshj/ext_date_config.m4.patch

With regards
Kamesh Jayachandran

On Wed, 29 Jun 2005 21:09:31 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:

> On Wed, 29 Jun 2005, Kamesh Jayachandran wrote:
>
> > #include <php_config.h> this at the start of the file(ofcourse after the
> > guard) solves the problem.
>
> Should be fixed in CVS, please test.
>
> regards,
> Derick
>
> --
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

--
http://www.fastmail.fm - Access your email from home and the web

Derick Rethans

21 years ago

On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:

> Still have one small issue with it for NetWare.
> We decided to use autoconf based build for PHP-5.1 so we don't want to
> use config.nw.h(Soon will delete it from the source tree)
> This patch takes cares of it.
> http://www.ductape.net/~kameshj/ext_date_config.m4.patch

Committed.

Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

Kamesh Jayachandran

21 years ago

Thanks.
That was so fast.

With regards
Kamesh Jayachandran
On Thu, 30 Jun 2005 08:41:11 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:

> On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:
>
> > Still have one small issue with it for NetWare.
> > We decided to use autoconf based build for PHP-5.1 so we don't want to
> > use config.nw.h(Soon will delete it from the source tree)
> > This patch takes cares of it.
> > http://www.ductape.net/~kameshj/ext_date_config.m4.patch
>
> Committed.
>
> Derick
>
> --
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

--
http://www.fastmail.fm - Email service worth paying for. Try it for free