Everything

php

[PATCH]check for makedev in ext/posix(5.1 tree) (Build failure in NetWare)

php.internals

Kamesh Jayachandran

21 years ago

Hi Derick,
In NetWare there does not exist a function by name makedev.
The following patch checks for the existence of makedev and calls only
if it exists.

http://www.ductape.net/~kameshj/ext_posix_makedev.patch

Please apply the same.

Thanks in advance
With regards
Kamesh Jayachandran

--
http://www.fastmail.fm - I mean, what is it about a decent email service?

Derick Rethans

21 years ago

On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:

> Hi Derick,
> In NetWare there does not exist a function by name makedev.
> The following patch checks for the existence of makedev and calls only
> if it exists.
>
> http://www.ductape.net/~kameshj/ext_posix_makedev.patch

I see you're just commenting it out with an #ifdef, shouldn't there be
some sort of fallback? Does having mknod() on Netware still make sense
then?

Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

Kamesh Jayachandran

21 years ago

Hi Derick,
Our LibC implementation of mknod as of today allows creation of regular
file, regular dir and fifo only.
It does not support Character and Block device creation.
The documentation of NetWare LibC mandates dev argument to mknod to be
0.(Which currently the case with php_dev=0).
May be when makdev is implemented this code will automatically take care
of the new functionality without any change in the code with just the
change in new set of LibC headers.

With regards
Kamesh Jayachandran


On Thu, 30 Jun 2005 11:41:57 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:

> On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:
>
> > Hi Derick,
> > In NetWare there does not exist a function by name makedev.
> > The following patch checks for the existence of makedev and calls only
> > if it exists.
> >
> > http://www.ductape.net/~kameshj/ext_posix_makedev.patch
>
> I see you're just commenting it out with an #ifdef, shouldn't there be
> some sort of fallback? Does having mknod() on Netware still make sense
> then?
>
> Derick
>
> --
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

--
http://www.fastmail.fm - A fast, anti-spam email service.

Derick Rethans

21 years ago

On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:

> Hi Derick,
> Our LibC implementation of mknod as of today allows creation of regular
> file, regular dir and fifo only.
> It does not support Character and Block device creation.
> The documentation of NetWare LibC mandates dev argument to mknod to be
> 0.(Which currently the case with php_dev=0).
> May be when makdev is implemented this code will automatically take care
> of the new functionality without any change in the code with just the
> change in new set of LibC headers.

Ok, I'll add a warning then if a Char or Block device is requested,
but makedev is not available.

Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org

Kamesh Jayachandran

21 years ago

That is so nice Derick.

With regards
Kamesh Jayachandran
On Thu, 30 Jun 2005 12:00:30 +0200 (CEST), "Derick Rethans"
<derick@php.net> said:

> On Thu, 30 Jun 2005, Kamesh Jayachandran wrote:
>
> > Hi Derick,
> > Our LibC implementation of mknod as of today allows creation of regular
> > file, regular dir and fifo only.
> > It does not support Character and Block device creation.
> > The documentation of NetWare LibC mandates dev argument to mknod to be
> > 0.(Which currently the case with php_dev=0).
> > May be when makdev is implemented this code will automatically take care
> > of the new functionality without any change in the code with just the
> > change in new set of LibC headers.
>
> Ok, I'll add a warning then if a Char or Block device is requested,
> but makedev is not available.
>
> Derick
> --
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org

--
http://www.fastmail.fm - Access all of your messages and folders
wherever you are