Improvement to test script 'bug22414'

php.internals

Rob Vaughn

21 years ago
Attached is a universal 'diff' that adds a crc32() check to the 'passthru' test as well as an md5() test. This will help detect if there's a problem with md5() or crc32() unless both are failing, which indicates a problem with the 'mhash' functionality. Cheers, Rob

Marcus Börger

21 years ago
Hello Rob, just a short comment to everyone writing tests: never use '<?' in tests. marcus Monday, August 8, 2005, 9:07:24 PM, you wrote:
> Attached is a universal 'diff' that adds a crc32() check to the 'passthru' > test as well as an md5() test. This will help detect if there's a problem > with md5() or crc32() unless both are failing, which indicates a problem with > the 'mhash' functionality.
> Cheers, Rob
Best regards, Marcus

Rob Vaughn

21 years ago
Hello, I didn't write the test, I just added code to check the crc32() values, the rest is the original code. What should be used instead of '<?' out of curiousity? That's all I've ever used. Marcus Boerger wrote:

Marcus Börger

21 years ago
Hello Rob, Monday, August 8, 2005, 11:59:48 PM, you wrote:
> Hello,
> I didn't write the test, I just added code to check the crc32() values, the > rest is the original code. What should be used instead of '<?' out of > curiousity? That's all I've ever used.
You should use '<?php' since '<?' can be disabled by ini. Best regards, Marcus