5.1.0RC2

php.internals

Zeev Suraski

20 years ago
Any last minute additions to 5.1.0RC2 or can we roll it? Zeev

Pierre-Alain Joye

20 years ago
On 9/14/05, Zeev Suraski <zeev@zend.com> wrote:
> Any last minute additions to 5.1.0RC2 or can we roll it?
cd php-src/pear && wget http://pear.php.net/install-pear.phar for both sources and win32 releases. As a little reminder :) --Pierre

Greg Beaver

20 years ago
Pierre-Alain Joye wrote:
> On 9/14/05, Zeev Suraski <zeev@zend.com> wrote: > >>Any last minute additions to 5.1.0RC2 or can we roll it? > > > cd php-src/pear && wget http://pear.php.net/install-pear.phar > > for both sources and win32 releases. As a little reminder :)
Quick note: windows needs go-pear.phar, I will try to take care of this and also a little php script that will grab install-pear.phar if it isn't there, so that there is no need to wget install-pear.phar for the bundler, and the end-user can always grab the latest .phar. This way, there is no wget dependency, since Andi reports that it may not be available on all systems, and no hassle for the person installing. The script will not attempt to do proxying, people with complex internet connections will just have to download it themselves. Objections? Greg

Edin Kadribasic

20 years ago
Greg Beaver wrote:
> Pierre-Alain Joye wrote: > >>On 9/14/05, Zeev Suraski <zeev@zend.com> wrote: >> >> >>>Any last minute additions to 5.1.0RC2 or can we roll it? >> >> >> cd php-src/pear && wget http://pear.php.net/install-pear.phar >> >>for both sources and win32 releases. As a little reminder :) > > > Quick note: windows needs go-pear.phar, I will try to take care of this > and also a little php script that will grab install-pear.phar if it > isn't there, so that there is no need to wget install-pear.phar for the > bundler, and the end-user can always grab the latest .phar. > > This way, there is no wget dependency, since Andi reports that it may > not be available on all systems, and no hassle for the person > installing. The script will not attempt to do proxying, people with > complex internet connections will just have to download it themselves. > > Objections?
Here! :) I have modified the build system for windows already using Pierre's suggestion (install-peaer.phar). Please check the latest 5.1 snap: http://snaps.php.net/win32/php5.1-win32-200509141430.zip Edin

Greg Beaver

20 years ago
Edin Kadribasic wrote:
>Greg Beaver wrote: > > >>Pierre-Alain Joye wrote: >> >> >> >>>On 9/14/05, Zeev Suraski <zeev@zend.com> wrote: >>> >>> >>> >>> >>>>Any last minute additions to 5.1.0RC2 or can we roll it? >>>> >>>> >>>cd php-src/pear && wget http://pear.php.net/install-pear.phar >>> >>>for both sources and win32 releases. As a little reminder :) >>> >>> >>Quick note: windows needs go-pear.phar, I will try to take care of this >>and also a little php script that will grab install-pear.phar if it >>isn't there, so that there is no need to wget install-pear.phar for the >>bundler, and the end-user can always grab the latest .phar. >> >>This way, there is no wget dependency, since Andi reports that it may >>not be available on all systems, and no hassle for the person >>installing. The script will not attempt to do proxying, people with >>complex internet connections will just have to download it themselves. >> >>Objections? >> >> > >Here! :) > >I have modified the build system for windows already using Pierre's >suggestion (install-peaer.phar). > >Please check the latest 5.1 snap: >http://snaps.php.net/win32/php5.1-win32-200509141430.zip >
Great! There is only one issue with this, which is that install-pear.phar simply uses the default installation location. This means that since this is C:\php5, PEAR will be simply be installed there without any user input. If you simply switch out install-pear.phar for go-pear.phar, it will allow users to configure this completely. go-pear.phar is at: http://pear.php.net/go-pear.phar Thanks, Greg

Edin Kadribasic

20 years ago
Greg Beaver wrote:
> Great! There is only one issue with this, which is that > install-pear.phar simply uses the default installation location. This > means that since this is C:\php5, PEAR will be simply be installed there > without any user input. If you simply switch out install-pear.phar for > go-pear.phar, it will allow users to configure this completely. > go-pear.phar is at: > > http://pear.php.net/go-pear.phar
Ok. Please check out the next snap (in two hours or so). Edin

Pierre Joye

20 years ago
On 9/14/05, Greg Beaver <greg@chiaraquartet.net> wrote:
> http://pear.php.net/go-pear.phar
For the distros, let use the same system. If one would like to customize, he is free to use go.pear.phar at a later point. Regards, --PIerre

Andrey Hristov

20 years ago
Pierre Joye wrote:
> On 9/14/05, Greg Beaver <greg@chiaraquartet.net> wrote: > > >>http://pear.php.net/go-pear.phar > > > For the distros, let use the same system. If one would like to > customize, he is free to use go.pear.phar at a later point. > > Regards, > > --PIerre >
go-phear.phear :) intall-phear :) Andrey

Uwe Schindler

20 years ago
No NEW problems on Solaris 9, only with latest 5.1 snapshot: * "make test" still does not work * "make install" fails because some PEAR components are missing (see mail of Pierre) * configure prints out a lot of garbage when testing for bison (which is missing on my solaris machine) Uwe At 13:20 14.09.2005, Zeev Suraski wrote:
>Any last minute additions to 5.1.0RC2 or can we roll it? > >Zeev > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php >
----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany

Jani Taskinen

20 years ago
On Wed, 14 Sep 2005, Uwe Schindler wrote:
> * "make test" still does not work
Like..how?
> * configure prints out a lot of garbage when testing for bison (which is > missing on my solaris machine)
And the garbage is..? --Jani

Uwe Schindler

20 years ago
At 16:18 14.09.2005, you wrote:
>On Wed, 14 Sep 2005, Uwe Schindler wrote: > >>* "make test" still does not work > > Like..how?
I posted this one month ago (other thread). It fails when calling "test" with an empty expression: pangaeaw@pans1:~/install/php5-200509141230$ gmake test Build complete. (It is safe to ignore warnings about tempnam and tmpnam). /bin/sh: test: argument expected gmake: [test] Error 1 (ignored) pangaeaw@pans1:~/install/php5-200509141230$ 4.3 and 5.0 worked in the past.
>>* configure prints out a lot of garbage when testing for bison >>(which is missing on my solaris machine) > > And the garbage is..?
checking whether ln -s works... yes checking if compiler supports -R... yes checking for re2c... no configure: warning: You will need re2c 0.98 or later if you want to regenerate PHP parsers. checking for gawk... gawk checking for bison... no checking for byacc... no checking for bison version... ./configure: bison: not found AWK=gawk CC=gcc CFLAGS=-g -O2 CONFIGURE_COMMAND= './configure' '--prefix=/pangaea/gnu' '--enable-cli' '--with-nsapi=/pangaea/webserver61' '--with-sybase-ct=/opt/csw' '--with-mysql=/opt/csw/mysql4' '--enable-ftp' '--enable-versioning' '--enable-session' '--enable-trans-sid' '--with-zlib=/opt/csw' '--enable-mbstring=all' '--with-openssl=/opt/csw' '--with-gd' '--with-png-dir=/opt/csw' '--with-jpeg-dir=/opt/csw' '--with-ttf=/opt/csw' '--with-libxml-dir=/opt/csw' '--with-iconv=/opt/csw' '--with-iconv-dir=/opt/csw' '--with-xsl=/opt/csw' '--enable-soap' '--without-sqlite' '--enable-exif' '--with-curl=/opt/csw' '--with-curlwrappers' '--with-pdo-mysql=/opt/csw/mysql4' '--with-xmlrpc' '--without-pdo-sqlite' '--with-pdo-dblib=/opt/csw' CONFIG_SITE=/pangaea/gnu/share/config.site /pangaea/gnu/etc/config.site CPP=gcc -E CYGWIN= ECHO=/usr/ucb/echo EGREP=egrep EXTRA_VERSION=RC2-dev GCC=yes HOME=/pangaea HOSTNAME=pans1 HOSTTYPE=sparc ....... and more crap .... then: with_xsl=/opt/csw with_zlib=/opt/csw x_includes=NONE x_libraries=NONE invalid configure: warning: bison versions supported for regeneration of the Zend/PHP parsers: 1.28 1.35 1.75 1.875 2.0 (found: dummy.byacc). checking for flex... lex checking for yywrap in -ll... yes checking lex output file root... lex.yy checking whether yytext is a pointer... no checking for working const... yes checking for flex version... invalid configure: warning: flex versions supported for regeneration of the Zend/PHP parsers: 2.5.4 (found: ). checking whether to force non-PIC code in shared modules... no checking for pthreads_cflags... ^C But configure works. Greetings, Uwe ----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany

Jani Taskinen

20 years ago
On Wed, 14 Sep 2005, Uwe Schindler wrote:
> At 16:18 14.09.2005, you wrote: > > /bin/sh: test: argument expected > gmake: [test] Error 1 (ignored) > pangaeaw@pans1:~/install/php5-200509141230$
Do you know why this happens? :) (in Makefile, remove the -@ from the line below test:)
>>> * configure prints out a lot of garbage when testing for bison (which is >>> missing on my solaris machine)
Fixed in CVS. --Jani

Jani Taskinen

20 years ago
All fixed now. --Jani On Wed, 14 Sep 2005, Uwe Schindler wrote:
> > At 16:18 14.09.2005, you wrote: >> On Wed, 14 Sep 2005, Uwe Schindler wrote: >> >>> * "make test" still does not work >> >> Like..how? > > I posted this one month ago (other thread). > It fails when calling "test" with an empty expression: > > pangaeaw@pans1:~/install/php5-200509141230$ gmake test > > Build complete. > (It is safe to ignore warnings about tempnam and tmpnam). > > /bin/sh: test: argument expected > gmake: [test] Error 1 (ignored) > pangaeaw@pans1:~/install/php5-200509141230$ > > 4.3 and 5.0 worked in the past. > >>> * configure prints out a lot of garbage when testing for bison (which is >>> missing on my solaris machine) >> >> And the garbage is..? > > checking whether ln -s works... yes > checking if compiler supports -R... yes > checking for re2c... no > configure: warning: You will need re2c 0.98 or later if you want to regenerate > PHP parsers. > checking for gawk... gawk > checking for bison... no > checking for byacc... no > checking for bison version... ./configure: bison: not found > AWK=gawk > CC=gcc > CFLAGS=-g -O2 > CONFIGURE_COMMAND= './configure' '--prefix=/pangaea/gnu' '--enable-cli' > '--with-nsapi=/pangaea/webserver61' '--with-sybase-ct=/opt/csw' > '--with-mysql=/opt/csw/mysql4' '--enable-ftp' '--enable-versioning' > '--enable-session' '--enable-trans-sid' '--with-zlib=/opt/csw' > '--enable-mbstring=all' '--with-openssl=/opt/csw' '--with-gd' > '--with-png-dir=/opt/csw' '--with-jpeg-dir=/opt/csw' '--with-ttf=/opt/csw' > '--with-libxml-dir=/opt/csw' '--with-iconv=/opt/csw' > '--with-iconv-dir=/opt/csw' '--with-xsl=/opt/csw' '--enable-soap' > '--without-sqlite' '--enable-exif' '--with-curl=/opt/csw' > '--with-curlwrappers' '--with-pdo-mysql=/opt/csw/mysql4' '--with-xmlrpc' > '--without-pdo-sqlite' '--with-pdo-dblib=/opt/csw' > CONFIG_SITE=/pangaea/gnu/share/config.site /pangaea/gnu/etc/config.site > CPP=gcc -E > CYGWIN= > ECHO=/usr/ucb/echo > EGREP=egrep > EXTRA_VERSION=RC2-dev > GCC=yes > HOME=/pangaea > HOSTNAME=pans1 > HOSTTYPE=sparc > > ....... and more crap .... > > then: > with_xsl=/opt/csw > with_zlib=/opt/csw > x_includes=NONE > x_libraries=NONE > invalid > configure: warning: bison versions supported for regeneration of the Zend/PHP > parsers: 1.28 1.35 1.75 1.875 2.0 (found: dummy.byacc). > checking for flex... lex > checking for yywrap in -ll... yes > checking lex output file root... lex.yy > checking whether yytext is a pointer... no > checking for working const... yes > checking for flex version... invalid > configure: warning: flex versions supported for regeneration of the Zend/PHP > parsers: 2.5.4 (found: ). > checking whether to force non-PIC code in shared modules... no > checking for pthreads_cflags... ^C > > But configure works. > > Greetings, > Uwe > > > ----- > Uwe Schindler > thetaphi@php.net - http://www.php.net > NSAPI SAPI developer > Bremen, Germany > >
-- Donate @ http://pecl.php.net/wishlist.php/sniper

Pierre Joye

20 years ago
On 9/14/05, Uwe Schindler <thetaphi@php.net> wrote:
> No NEW problems on Solaris 9, only with latest 5.1 snapshot: > > * "make test" still does not work > * "make install" fails because some PEAR components are missing (see > mail of Pierre)
Uwe, _you_ have to do it while testing from CVS :) See pear/install-pear.txt. --Pierre

Andi Gutmans

20 years ago
Yep, Observer and friends should be renamed to Spl*. At 04:20 AM 9/14/2005, Zeev Suraski wrote:

Marcus Börger

20 years ago
Hello Zeev, i tried to get any feedback from You or andi regarding SPL but none of you replied so far. Question is whether i should rename some of the new interfaces and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL and instead provide class constants whcih we can do right now? Yes i know that might be BC issue but i'd say it is worth the little break and i am quite sure we shouldn't do it after 5.1 is out. And Last but not least i'd like to MFH two of the new classes if you don#t mind. marcus Wednesday, September 14, 2005, 1:20:21 PM, you wrote:
> Any last minute additions to 5.1.0RC2 or can we roll it?
> Zeev
Best regards, Marcus

Edin Kadribasic

20 years ago
Marcus Boerger wrote:
> Hello Zeev, > > i tried to get any feedback from You or andi regarding SPL but none of you > replied so far. Question is whether i should rename some of the new interfaces > and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL > and instead provide class constants whcih we can do right now? Yes i know > that might be BC issue but i'd say it is worth the little break and i am > quite sure we shouldn't do it after 5.1 is out. And Last but not least i'd > like to MFH two of the new classes if you don#t mind.
Hm, prefixing "new" interfaces and classes with Spl is the worst thing one could do IMHO. Wouldn't it be the best to prefix *all* Spl interfaces and classes? Edin

Jessie Hernandez

20 years ago
I agree with Edin. To be consistent, either all interfaces and classes should be prefixed or none should be prefixed. On the other hand, prefixing all the old classes/interfaces will cause BC breaks. <shameless-plug> This is one case where namespaces are useful. With my namespace patch, all that would have to be done is to name the class as SPL:Observer. Users can either implement SPL:Observer or first "import SPL:Observer;" and then implement Observer. </shameless-plug> Regards, Jessie "Edin Kadribasic" <edink@emini.dk> wrote in message news:43283A26.7060000@emini.dk...
> Marcus Boerger wrote: > > Hello Zeev, > > > > i tried to get any feedback from You or andi regarding SPL but none of
you
> > replied so far. Question is whether i should rename some of the new
interfaces
> > and classes to be prefixed by 'Spl'. Also should i drop all constants in
SPL
> > and instead provide class constants whcih we can do right now? Yes i
know
> > that might be BC issue but i'd say it is worth the little break and i am > > quite sure we shouldn't do it after 5.1 is out. And Last but not least
i'd

Ondrej Ivanič

20 years ago
Jessie Hernandez wrote:
> <shameless-plug> > This is one case where namespaces are useful. With my namespace patch, all > that would have to be done is to name the class as SPL:Observer. Users can > either implement SPL:Observer or first "import SPL:Observer;" and then > implement Observer. > </shameless-plug>
Yes, this is a right task for a namespaces. What is current status of a patch? It will be included?
-- Ondrej Ivanič (ondrej@kmit.sk

David Zülke

20 years ago
> What is current status of a patch? It will be included?
I really hope so (for PHP6, that is). Andi said he'd have a look at the patch some time ago. I'd love to know what he and the others "in charge" think about this matter. - David

Marcus Börger

20 years ago
Hello Jessie, well the best solution would be to drop the 'Spl' prefix for 5.1 and wait for namespaces since they are imo the only solution. marcus Wednesday, September 14, 2005, 5:34:45 PM, you wrote:
> I agree with Edin. To be consistent, either all interfaces and classes > should be prefixed or none should be prefixed. On the other hand, prefixing > all the old classes/interfaces will cause BC breaks.
> <shameless-plug> > This is one case where namespaces are useful. With my namespace patch, all > that would have to be done is to name the class as SPL:Observer. Users can > either implement SPL:Observer or first "import SPL:Observer;" and then > implement Observer. > </shameless-plug>
> Regards,
> Jessie
> "Edin Kadribasic" <edink@emini.dk> wrote in message > news:43283A26.7060000@emini.dk... >> Marcus Boerger wrote: >> > Hello Zeev, >> > >> > i tried to get any feedback from You or andi regarding SPL but none of > you >> > replied so far. Question is whether i should rename some of the new > interfaces >> > and classes to be prefixed by 'Spl'. Also should i drop all constants in > SPL >> > and instead provide class constants whcih we can do right now? Yes i > know >> > that might be BC issue but i'd say it is worth the little break and i am >> > quite sure we shouldn't do it after 5.1 is out. And Last but not least > i'd >> > like to MFH two of the new classes if you don#t mind. >> >> Hm, prefixing "new" interfaces and classes with Spl is the worst thing >> one could do IMHO. Wouldn't it be the best to prefix *all* Spl >> interfaces and classes? >> >> Edin
Best regards, Marcus

Marcus Börger

20 years ago
Hello Edin, well imho it makes no sense to prefix all the iterators with Spl and also most of them are released already with 5.0. Changing those is to big of a BC issue isn't it? I mean it is different from changing a few consts very rarely used to class consts. marcus Wednesday, September 14, 2005, 4:56:38 PM, you wrote:
> Marcus Boerger wrote: >> Hello Zeev, >> >> i tried to get any feedback from You or andi regarding SPL but none of you >> replied so far. Question is whether i should rename some of the new interfaces >> and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL >> and instead provide class constants whcih we can do right now? Yes i know >> that might be BC issue but i'd say it is worth the little break and i am >> quite sure we shouldn't do it after 5.1 is out. And Last but not least i'd >> like to MFH two of the new classes if you don#t mind.
> Hm, prefixing "new" interfaces and classes with Spl is the worst thing > one could do IMHO. Wouldn't it be the best to prefix *all* Spl > interfaces and classes?
> Edin
Best regards, Marcus

Edin Kadribasic

20 years ago
Marcus Boerger wrote:
> Hello Edin, > > well imho it makes no sense to prefix all the iterators with Spl and also > most of them are released already with 5.0. Changing those is to big of a BC > issue isn't it? I mean it is different from changing a few consts very > rarely used to class consts.
Marcus, This issue came up before. I remember the instance where you added class File. Many people, including myself, said that all Spl classes should be prefixed, but you have just ignored those comments. Now, you claim they cannot be renamed due to the BC concerns... go figure. Edin

Sebastian Bergmann

20 years ago
Edin Kadribasic schrieb:
> Now, you claim they cannot be renamed due to the BC concerns
I think we should break BC for PHP 5.1 and prefix the existing classes with SPL. This is better than the current state in HEAD and PHP_5_1 which is inconsistent. Hopefully we will have namespaces in PHP 6.0 by which time we can break BC one final time and move all SPL classes to their own namespace.
-- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69

Marcus Börger

20 years ago
Hello Sebastian, yeah uys piss me off :-) Thursday, September 15, 2005, 2:08:53 PM, you wrote:
> Edin Kadribasic schrieb: >> Now, you claim they cannot be renamed due to the BC concerns
> I think we should break BC for PHP 5.1 and prefix the existing classes > with SPL. This is better than the current state in HEAD and PHP_5_1 > which is inconsistent.
> Hopefully we will have namespaces in PHP 6.0 by which time we can break > BC one final time and move all SPL classes to their own namespace.
> -- > Sebastian Bergmann http://www.sebastian-bergmann.de/ > GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69
Best regards, Marcus

Marcus Börger

20 years ago
Hello Sebastian, honestly why do you want to prefix iterators? and secondly i'd be just plain stupid to prefix the exception classes. In the end we should move the exception classes into the engine anyways. But who cares what i say marcus Thursday, September 15, 2005, 2:08:53 PM, you wrote:
> Edin Kadribasic schrieb: >> Now, you claim they cannot be renamed due to the BC concerns
> I think we should break BC for PHP 5.1 and prefix the existing classes > with SPL. This is better than the current state in HEAD and PHP_5_1 > which is inconsistent.
> Hopefully we will have namespaces in PHP 6.0 by which time we can break > BC one final time and move all SPL classes to their own namespace.
> -- > Sebastian Bergmann http://www.sebastian-bergmann.de/ > GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69
Best regards, Marcus

Sebastian Bergmann

20 years ago
Marcus Boerger schrieb:
> honestly why do you want to prefix iterators? and secondly i'd be > just plain stupid to prefix the exception classes.
Bugger, I forgot that those two (iterators and exceptions) are part of SPL for a second. They're so essential, IMHO, that I thought them part of the core somehow :)
-- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69

Sebastian Bergmann

20 years ago
Sebastian Bergmann schrieb:
> Bugger, I forgot that those two
Just to clarify for those who do not know that "Bugger" can be used a phrase along the lines of "Oh my God!": I did not call Marcus a bugger, which would be, given certain meanings of the word as a noun, really bad name calling.
-- Sebastian Bergmann http://www.sebastian-bergmann.de/ GnuPG Key: 0xB85B5D69 / 27A7 2B14 09E4 98CD 6277 0E5B 6867 C514 B85B 5D69

Wez Furlong

20 years ago
The "Oh my God!" meaning comes from the fuller phrase "Bugger me!"; neither usage is appropriate for polite company. --Wez. On 9/15/05, Sebastian Bergmann <sb@sebastian-bergmann.de> wrote:

Lukas Smith

20 years ago
Sebastian Bergmann wrote:
> Marcus Boerger schrieb: > >>honestly why do you want to prefix iterators? and secondly i'd be >>just plain stupid to prefix the exception classes. > > > Bugger, I forgot that those two (iterators and exceptions) are part of > SPL for a second. They're so essential, IMHO, that I thought them part > of the core somehow :)
AFAIK Marcus spend quite a considerable time during the conf to add prefixes or some other namespacing steps to all global symbols during the php|works conferences except for Iterators and Exceptions. I think for Iterators and Exceptions they are sort of postfix namespaced. I think we should just come up with a "userland global symbol naming guideline" in the manual where we give users a guideline on the kinds of things php may expand to in the global symbol table in the future and what sort of userland naming policy we recommend to not run into trouble. regards, Lukas

Andi Gutmans

20 years ago
I am sure I answered but I see Zeev has now (pretty much what I answered too :) At 07:39 AM 9/14/2005, Marcus Boerger wrote:

Marcus Börger

20 years ago
Hello Andi, ok, i am on it right now (the one answer was from today, i received it while i was typing the other). regards marcus Wednesday, September 14, 2005, 9:55:32 PM, you wrote:
> I am sure I answered but I see Zeev has now (pretty much what I answered too :)
> At 07:39 AM 9/14/2005, Marcus Boerger wrote: >>Hello Zeev, >> >> i tried to get any feedback from You or andi regarding SPL but none of you >>replied so far. Question is whether i should rename some of the new interfaces >>and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL >>and instead provide class constants whcih we can do right now? Yes i know >>that might be BC issue but i'd say it is worth the little break and i am >>quite sure we shouldn't do it after 5.1 is out. And Last but not least i'd >>like to MFH two of the new classes if you don#t mind. >> >>marcus >> >>Wednesday, September 14, 2005, 1:20:21 PM, you wrote: >> >> > Any last minute additions to 5.1.0RC2 or can we roll it? >> >> > Zeev >> >> >> >> >>Best regards, >> Marcus
Best regards, Marcus

Marcus Börger

20 years ago
Hello Andi, hello Zeev, MFH and change towards class constants is done. The only part being new inside SPL now is the ability of spl's autoload to work with non static loader methods. Do you think i should move that into 5.1 as well? regards marcus Wednesday, September 14, 2005, 9:55:32 PM, you wrote:

Zeev Suraski

20 years ago
At 17:39 14/09/2005, Marcus Boerger wrote:
>Hello Zeev, > > i tried to get any feedback from You or andi regarding SPL but none of you >replied so far. Question is whether i should rename some of the new interfaces >and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL >and instead provide class constants whcih we can do right now? Yes i know >that might be BC issue but i'd say it is worth the little break and i am >quite sure we shouldn't do it after 5.1 is out.
Yes, we should do the renaming and rescoping. Can you do it today so that we can roll RC2 tomorrow?
> And Last but not least i'd >like to MFH two of the new classes if you don#t mind.
I personally don't mind. Make sure they're prefixed :) Zeev

Marcus Börger

20 years ago
Hello Zeev, phew i take a deep breathe and give my best marcus Wednesday, September 14, 2005, 4:45:32 PM, you wrote:
> At 17:39 14/09/2005, Marcus Boerger wrote: >>Hello Zeev, >> >> i tried to get any feedback from You or andi regarding SPL but none of you >>replied so far. Question is whether i should rename some of the new interfaces >>and classes to be prefixed by 'Spl'. Also should i drop all constants in SPL >>and instead provide class constants whcih we can do right now? Yes i know >>that might be BC issue but i'd say it is worth the little break and i am >>quite sure we shouldn't do it after 5.1 is out.
> Yes, we should do the renaming and rescoping. Can you do it today so that > we can roll RC2 tomorrow?
>> And Last but not least i'd >>like to MFH two of the new classes if you don#t mind.
> I personally don't mind. Make sure they're prefixed :)
> Zeev
Best regards, Marcus

Antony Dovgal

20 years ago
On 14.09.2005 15:20, Zeev Suraski wrote:
> Any last minute additions to 5.1.0RC2 or can we roll it?
If it's not too late I'd like to fix http://bugs.php.net/bug.php?id=34505 before RC2. It'll require addition of zend_unmangle_property_name_ex() and changing several files to use it instead of zend_unmangle_property_name() (nothing serious though), as the latter may lead to segfaults etc. I'll post the patch in the morning.
-- Wbr, Antony Dovgal

Antony Dovgal

20 years ago
On 15.09.2005 03:24, Antony Dovgal wrote:
> On 14.09.2005 15:20, Zeev Suraski wrote: >> Any last minute additions to 5.1.0RC2 or can we roll it? > > If it's not too late I'd like to fix http://bugs.php.net/bug.php?id=34505 before RC2. > > It'll require addition of zend_unmangle_property_name_ex() and changing > several files to use it instead of zend_unmangle_property_name() (nothing serious > though), as the latter may lead to segfaults etc. > > I'll post the patch in the morning.
Ok, here it is (divided into two parts).
-- Wbr, Antony Dovgal

Jani Taskinen

20 years ago
Just commit. On Thu, 15 Sep 2005, Antony Dovgal wrote:
> On 15.09.2005 03:24, Antony Dovgal wrote: >> On 14.09.2005 15:20, Zeev Suraski wrote: >>> Any last minute additions to 5.1.0RC2 or can we roll it? >> >> If it's not too late I'd like to fix http://bugs.php.net/bug.php?id=34505 >> before RC2. >> >> It'll require addition of zend_unmangle_property_name_ex() and changing >> several files to use it instead of zend_unmangle_property_name() (nothing >> serious though), as the latter may lead to segfaults etc. >> >> I'll post the patch in the morning. > > Ok, here it is (divided into two parts). > >
-- Donate @ <http://pecl.php.net/wishlist.php/sniper> Disclaimer: Donating money may make me happier and friendlier for a limited period!

Antony Dovgal

20 years ago
On 14.09.2005 15:20, Zeev Suraski wrote:
> Any last minute additions to 5.1.0RC2 or can we roll it?
It seems that #27145 has crept back into 5.1 with a copy/paste typo. Here is the patch for it too.
-- Wbr, Antony Dovgal

Jani Taskinen

20 years ago
Just commit (tm). On Thu, 15 Sep 2005, Antony Dovgal wrote:
> On 14.09.2005 15:20, Zeev Suraski wrote: >> Any last minute additions to 5.1.0RC2 or can we roll it? > > It seems that #27145 has crept back into 5.1 with a copy/paste typo. > Here is the patch for it too. > >
-- Donate @ <http://pecl.php.net/wishlist.php/sniper> Disclaimer: Donating money may make me happier and friendlier for a limited period!