Everything

php

Home » Project » Newsgroups » php.internals » change of variable name from tzname to formal_tzname »

change of variable name from tzname to formal_tzname

php.internals

Kamesh Jayachandran

20 years ago

Hi Derick,
From Yesterday(06/10/2005) onwards NetWare php-5.1 autotests were
failing because of a segfault from tests/lang/023.phpt which makes one
mktime call.
When delved for the cause it seems that In NetWare LibC SDK's time.h
tzname is expanded to ___tzname() this cause the C preprocessor to
change the tzname to vague ___tzname function call in
php_date_parse_tzfile().
Changing the variable name tzname to formal_tzname or anything more
pleasing in php_date_parse_tzfile should fix it.

http://puggy.symonds.net/~kameshj/php_date.c.patch

Can you check in this?

With regards
Kamesh Jayachandran

--
http://www.fastmail.fm - And now for something completely different

Derick Rethans

20 years ago

Hello,

On Fri, 7 Oct 2005, Kamesh Jayachandran wrote:

> From Yesterday(06/10/2005) onwards NetWare php-5.1 autotests were
> failing because of a segfault from tests/lang/023.phpt which makes one
> mktime call.
> When delved for the cause it seems that In NetWare LibC SDK's time.h
> tzname is expanded to ___tzname() this cause the C preprocessor to
> change the tzname to vague ___tzname function call in
> php_date_parse_tzfile().
> Changing the variable name tzname to formal_tzname or anything more
> pleasing in php_date_parse_tzfile should fix it.
>
> http://puggy.symonds.net/~kameshj/php_date.c.patch
>
> Can you check in this?

Yes, I just committed it.

regards,
Derick

--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org