Everything

php

filter, state of the beast, take over

php.internals

Pierre Joye

20 years ago

Hello,

The upcoming default PHP Input filter is orphaned. There is no official
active maintainer, or not active.

I commited most of the required changes and it is getting really neat.
Some small APIs changes are still required (separate the options from
the flags in input_get).

Here is a short list of the "recent" changes:

- support of php pcre expressions  (will support caching system)

- added input_get_args, fetches all input in one call

- Added FILTER_FLAG_SCALAR and FILTER_FLAG_ARRAY , allows or
not array values

- Basic IPv6 validation support

- support for custom decimal separator

- INT and Float filters trim the values before the validations (spaces
only)

- NULL is returned when a value has not been found or set and FALSE if
the validation failed

See examples and tests in cvs [5].

I like to take over the development and continue my good work on this
extension,is there any objections?

I do not want to take unilateral decisions but I do want the
best possible extension. It is a must if we are going to enable it by
default in php 6 and bundled it in a 5.x release.


-- Pierre


[1] http://www.beeblex.com/lists/index.php/php.internals/22690
[2] http://www.beeblex.com/lists/index.php/php.internals/22705
[3] http://www.beeblex.com/lists/index.php/php.internals/23064
[4] http://cvs.php.net/pecl/filter

Edin Kadribasic

20 years ago

> I like to take over the development and continue my good work on this
> extension,is there any objections?

I see no reason for a willing developer not to maintain the code he
wants to.

I have some questions regarding filter: does it in any way affect
perfomance or input in default configuration?

I'm asking this since it was the plan to add and enable this by default
in 5.2, right?

Edin

Rasmus Lerdorf

20 years ago

Pierre wrote:

> The upcoming default PHP Input filter is orphaned. There is no official
> active maintainer, or not active.

By what standard?  We don't all work on the same schedule which doesn't
mean we aren't active.  I have been fixing things too in this extension
within the past 2 weeks.

> I commited most of the required changes and it is getting really neat.
> Some small APIs changes are still required (separate the options from
> the flags in input_get).
>
> Here is a short list of the "recent" changes:
>
> - support of php pcre expressions  (will support caching system)
>
> - added input_get_args, fetches all input in one call
>
> - Added FILTER_FLAG_SCALAR and FILTER_FLAG_ARRAY , allows or
>   not array values
>
> - Basic IPv6 validation support
>
> - support for custom decimal separator
>
> - INT and Float filters trim the values before the validations (spaces
>   only)
>
> - NULL is returned when a value has not been found or set and FALSE if
>   the validation failed
>
> See examples and tests in cvs [5].
>
> I like to take over the development and continue my good work on this
> extension,is there any objections?

What do you mean take over?  Just keep doing what you are doing.  Some
of your patches have some issues and need to be worked out, but most of
them are fine.

-Rasmus

Pierre Joye

20 years ago

Hi Rasmus,

On 5/24/06, Rasmus Lerdorf <rasmus@lerdorf.com> wrote:

> What do you mean take over?  Just keep doing what you are doing.  Some
> of your patches have some issues and need to be worked out, but most of
> them are fine.

I would like to get the rights:

- commit changes again, this problem is solved, you did it in this answer

- to continue to add or change things as I did but in a more efficient way:
commit (as experimental) and ask for feedbacks instead of asking for feedbacks
before the commits

- to release pecl/filter as often as required. Release filter through
pecl will bring
more users and visibility. It will help to see how it works and what
has to be changed

Short version: to activelly lead the development, in cooperation with
the interested people in internals and our users.

Again, that does not mean I will take unilateral decisions, it is only
necessary to bring this extension to a stable and useable state.

I hope it is more clear now  :-)

Cheers,
--Pierre

Derick Rethans

20 years ago

On Wed, 24 May 2006, Pierre wrote:

> I like to take over the development and continue my good work on this
> extension,is there any objections?

Yes, you can discuss your patches just like you expect anybody else does
for patches against the extension that you maintain.

> I do not want to take unilateral decisions but I do want the
> best possible extension.

You're making those anyway as you're committing patches that you *know*
I was opposed to without discussing them further.

Derick

Pierre Joye

20 years ago

On 5/25/06, Derick Rethans <derick@php.net> wrote:

> > I do not want to take unilateral decisions but I do want the
> > best possible extension.
>
> You're making those anyway as you're committing patches that you *know*
> I was opposed to without discussing them further.

Which discssions are you refering to?

--Pierre

Derick Rethans

20 years ago

On Thu, 25 May 2006, Pierre wrote:

> On 5/25/06, Derick Rethans <derick@php.net> wrote:
>
> > > I do not want to take unilateral decisions but I do want the
> > > best possible extension.
> >
> > You're making those anyway as you're committing patches that you *know*
> > I was opposed to without discussing them further.
>
> Which discssions are you refering to?

The ones on float/decimal separator for example.

Derick

Pierre Joye

20 years ago

On Fri, 26 May 2006 09:14:30 +0200 (CEST)
derick@php.net (Derick Rethans) wrote:

> On Thu, 25 May 2006, Pierre wrote:
>
> > On 5/25/06, Derick Rethans <derick@php.net> wrote:
> >
> > > > I do not want to take unilateral decisions but I do want the
> > > > best possible extension.
> > >
> > > You're making those anyway as you're committing patches that you
> > > *know* I was opposed to without discussing them further.
> >
> > Which discssions are you refering to?
>
> The ones on float/decimal separator for example.

I must have missed it, any link?

-- Pierre