New output control code ready for HEAD

php.internals

Michael Wallner

20 years ago
Hi, After receiving some positive words to go ahead on IRC, I finished porting the output control implementation to HEAD. If there are no further objections, I'm going to commit soonish, so it can be tested. Patch: http://dev.iworks.at/PATCHES/output/ob-HEAD.txt References: http://marc.theaimsgroup.com/?l=php-dev&m=114104110826804&w=2 http://marc.theaimsgroup.com/?l=php-dev&m=114210732600710&w=2 http://marc.theaimsgroup.com/?l=php-dev&m=114595213508582&w=2 Todo: - Functions which accepted a plain char* in the simpler older world now require a zval*, I'm not sure if this is the best way. - Improve existing output handlers to benefit from the new implementation. Regards,
-- Michael

Rasmus Lerdorf

20 years ago
Like I said on irc, I think getting this into HEAD is the only way for us to have any chance of figuring out what might be affected by it. -Rasmus Michael Wallner wrote:

Marcus Börger

20 years ago
Hello Rasmus, helly list, i can only agree to this. People do not care unless they are affected. I am quite sure noone ever had a peep into this patch of which the first version are out since weeks. The idea is generally good and making the ob facility maintainable again is imo worth a bit of a hickup in development. For PHP 6 we still have plenty of time anyway. So i am sure Mike can fixy all the issues. So my advise is to specify a commit date, say tuesday or wednesday next week and commit if no real aregument against is brought up by now. How about that? best regards marcus p.s.: to list, is this now a discussion? or do we need specific people to join? Friday, May 26, 2006, 2:40:28 PM, you wrote:
> Like I said on irc, I think getting this into HEAD is the only way for > us to have any chance of figuring out what might be affected by it.
> -Rasmus
> Michael Wallner wrote: >> Hi, >> >> After receiving some positive words to go ahead on IRC, I finished >> porting the output control implementation to HEAD. >> >> If there are no further objections, I'm going to commit soonish, so it >> can be tested. >> >> Patch: >> http://dev.iworks.at/PATCHES/output/ob-HEAD.txt >> >> References: >> http://marc.theaimsgroup.com/?l=php-dev&m=114104110826804&w=2 >> http://marc.theaimsgroup.com/?l=php-dev&m=114210732600710&w=2 >> http://marc.theaimsgroup.com/?l=php-dev&m=114595213508582&w=2 >> >> Todo: >> - Functions which accepted a plain char* in the simpler older >> world now require a zval*, I'm not sure if this is the best way. >> - Improve existing output handlers to benefit from the new >> implementation. >> >> Regards,
Best regards, Marcus

Pierre Joye

20 years ago
On 5/27/06, Marcus Boerger <helly@php.net> wrote:
> Hello Rasmus, helly list, > So my advise is to specify a commit date, say tuesday or > wednesday next week and commit if no real aregument against is brought up by > now. How about that?
Fine, as long as it works nicelly with Unicode.
> p.s.: to list, is this now a discussion? or do we need specific people to > join?
It is. It is even better as many other "discussions" as it is a separate and catchable topic, and not lost in an endless FUD covering millions of topics.