[PATCH] Enable LC_MESSAGES locale, when gettext is compiled

php.internals

Melvyn Sopacua

23 years ago
Hi, attached a small fix, for OS's who do not natively support the LC_MESSAGES locale. When on these platforms the gettext extension is compiled in, it is still useless, since libintl.h is the one defining the locale. Tested and working, no side-effects observed. With kind regards, Melvyn Sopacua <?php include("not_reflecting_employers_views.txt"); ?>

Moriyoshi Koizumi

23 years ago
I think this patch should go to the PHP_4_3 branch too. Moriyoshi Melvyn Sopacua <msopacua@php.net> wrote:

Jani Taskinen

23 years ago
On Mon, 26 May 2003, Melvyn Sopacua wrote:
>attached a small fix, for OS's who do not natively support the LC_MESSAGES >locale.
What OSes might those be?
>When on these platforms the gettext extension is compiled in, it is still >useless, since libintl.h is the one defining the locale.
What is useless, this patch or gettext?
>Tested and working, no side-effects observed.
Feel free to commit to the 4_3 branch. --Jani

Melvyn Sopacua

23 years ago
On Mon, 26 May 2003, Jani Taskinen wrote: JT>>> On Mon, 26 May 2003, Melvyn Sopacua wrote: JT>>> JT>>> >attached a small fix, for OS's who do not natively support the LC_MESSAGES JT>>> >locale. JT>>> JT>>> What OSes might those be? The more conservative ones :). BSD/OS for one. Not sure about Open/NetBSD. JT>>> >When on these platforms the gettext extension is compiled in, it is still JT>>> >useless, since libintl.h is the one defining the locale. JT>>> JT>>> What is useless, this patch or gettext? Neither. Having compiled in gettext is useless, as gettext needs the LC_MESSAGES locale set. JT>>> >Tested and working, no side-effects observed. JT>>> JT>>> Feel free to commit to the 4_3 branch. Done.
-- Melvyn