[PATCH] Net_URL

php.internals

Alexei

19 years ago
Here is a patch for // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ // // Net_URL Class Misspelled variable in function Net_URL::setProtocol() 418c418 < $this->port = is_null($port) ? $this->getStandardPort($protocal) : $port; ---
> $this->port = is_null($port) ?
$this->getStandardPort($protocol) : $port;

Jan Lehnardt

19 years ago
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey Alexei, Thanks you for your patch! I committed it. For future reference however, these patches should go into the bug system[1] and there is a dedicated PEAR development related list[2]. Best, Jan - -- [1] http://pear.php.net/bugs/search.php?cmd=display&package_name%5B% 5D=Net_URL [2] pear-dev@lists.php.net On Sun 24 Sep 2006, at 24 Sep 23:11, Alexei wrote:
> Here is a patch for > > // $Id: URL.php,v 1.42 2005/10/29 11:17:56 dufuz Exp $ > // > // Net_URL Class > > Misspelled variable in function Net_URL::setProtocol() > > > 418c418 > < $this->port = is_null($port) ? $this->getStandardPort > ($protocal) : $port; > --- > > $this->port = is_null($port) ? $this->getStandardPort > ($protocol) : $port; > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (Darwin) iD8DBQFFFviH7KW8t7uWVrARAh0xAJ9rAm/qs/K+lYcN7GFnzgt6ksCz2wCgxRcY uqZaLNQ9ZFt1vhu2lPiuxzU= =Df9R -----END PGP SIGNATURE-----

Alexei

19 years ago
Thanks Jan Sorry guys, description of how to submit patches was a bit confusing on pear website. Alexei Jan Lehnardt wrote:

Johannes Schlueter

19 years ago
Please send this to an PEAR list or report a bug at pear.php.net, internals is the wrong place for this. And as a related note: diff -u is way better readable and preferred. johannes Alexei wrote: