imagefilter() duplicate "wrong param count" message

php.internals

Hannes Magnusson

19 years ago
imagefilter() currently throws double "wrong param count" error. Attached is a patch for HEAD that fixes it. -Hannes

Pierre Joye

19 years ago
Hello, On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote:
> imagefilter() currently throws double "wrong param count" error. > Attached is a patch for HEAD that fixes it.
You just asked me on IRC and I told you to post one patch to fix all similar issues at once. Why are you posting this question here again? --Pierre

Hannes Magnusson

19 years ago
On 10/8/06, Pierre <pierre.php@gmail.com> wrote:
> Hello, > > On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > > imagefilter() currently throws double "wrong param count" error. > > Attached is a patch for HEAD that fixes it. > > You just asked me on IRC and I told you to post one patch to fix all > similar issues at once. Why are you posting this question here again?
Because I've already fixed all the others (I could find). Everyone seem to be happy about it. Since you've been flaming me for every single commit I make into ext you are involved with I decided to post the patch here (as per your request). -Hannes

Pierre Joye

19 years ago
Hello, On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote:
> On 10/8/06, Pierre <pierre.php@gmail.com> wrote: > > Hello, > > > > On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > > > imagefilter() currently throws double "wrong param count" error. > > > Attached is a patch for HEAD that fixes it. > > > > You just asked me on IRC and I told you to post one patch to fix all > > similar issues at once. Why are you posting this question here again? > > Because I've already fixed all the others (I could find). Everyone > seem to be happy about it. > > Since you've been flaming me for every single commit I make into ext > you are involved with I decided to post the patch here (as per your > request).
I did not flame you, I asked you to ask before making large changes, like the last one you did in zip. But asking for an error message fix is useless, just commit it, don't waste time to ask half of the world. I really don't understand the point to discuss that again and again. It is so easy to post a mail with one patch and that's it, especially for such non critical patches. But no, it has to be difficult and discussed during hours. Thanks for your understanding and work. --Pierre

Hannes Magnusson

19 years ago
On 10/8/06, Pierre <pierre.php@gmail.com> wrote:
> Hello, > > On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > > On 10/8/06, Pierre <pierre.php@gmail.com> wrote: > > > Hello, > > > > > > On 10/8/06, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > > > > imagefilter() currently throws double "wrong param count" error. > > > > Attached is a patch for HEAD that fixes it. > > > > > > You just asked me on IRC and I told you to post one patch to fix all > > > similar issues at once. Why are you posting this question here again? > > > > Because I've already fixed all the others (I could find). Everyone > > seem to be happy about it. > > > > Since you've been flaming me for every single commit I make into ext > > you are involved with I decided to post the patch here (as per your > > request). > > I did not flame you, I asked you to ask before making large changes, > like the last one you did in zip. But asking for an error message fix > is useless, just commit it, don't waste time to ask half of the world.
Now you got me confused. The last change I made in ext/zip was an error message fix. After I made it you complained over not asking you first. Now you say "don't waste time asking"?
> > I really don't understand the point to discuss that again and again. > It is so easy to post a mail with one patch and that's it, especially > for such non critical patches. But no, it has to be difficult and > discussed during hours.
I thought I was doing it now? -Hannes