Everything

php

PHP 5.2.0 Openssl PKCS12 patch

php.internals

Marc Delling

19 years ago

Hello, I'm Marc and I'm new to this list. Whew! That was easy!

I've read in the archive about a patch for supporting openssl pkcs12,
but nothing seems to be done so far. Since I was missing the same
thing when trying to code a quick-and-dirty certificate management
webapp I decided to write a patch by myself. Is there still need for
a patch introducing such functions? To whom should I post it? (I've
included it in this posting for discussion) Where does the
documentation go?

The patch

Marcus Börger

19 years ago

Hello Marc,

you cannot use c++ style comments '//', see CODING_STANDARDS.
Rest looks good on a first glimpse.

best regards
marcus

Friday, December 15, 2006, 6:27:13 PM, you wrote:

> Hello, I'm Marc and I'm new to this list. Whew! That was easy!

> I've read in the archive about a patch for supporting openssl pkcs12,
> but nothing seems to be done so far. Since I was missing the same
> thing when trying to code a quick-and-dirty certificate management
> webapp I decided to write a patch by myself. Is there still need for
> a patch introducing such functions? To whom should I post it? (I've
> included it in this posting for discussion) Where does the
> documentation go?

> The patch

Best regards,
Marcus

Pierre Joye

19 years ago

Hi Marc,

On 12/15/06, Marc Delling <delling@silpion.de> wrote:

> Hello, I'm Marc and I'm new to this list. Whew! That was easy!
>
> I've read in the archive about a patch for supporting openssl pkcs12,

First, thanks for this patch :)

> but nothing seems to be done so far. Since I was missing the same
> thing when trying to code a quick-and-dirty certificate management
> webapp I decided to write a patch by myself. Is there still need for
> a patch introducing such functions? To whom should I post it? (I've
> included it in this posting for discussion) Where does the
> documentation go?

The best would be to open a bug. I store your patch locally already
but a bug report will help me to do not forget as it is too late for
5.2 (5.2.1 release process just started).  I will merge your patch in
HEAD after I review it, add some tests and cleanup (cs, ...).

--Pierre

Moritz Bechler

19 years ago

Hi

>> Hello, I'm Marc and I'm new to this list. Whew! That was easy!
>>
>> I've read in the archive about a patch for supporting openssl pkcs12,
>
> First, thanks for this patch :)

Quite nice you did this, I was just thinking about doing it myself ;)

>
>> but nothing seems to be done so far. Since I was missing the same
>> thing when trying to code a quick-and-dirty certificate management
>> webapp I decided to write a patch by myself. Is there still need for
>> a patch introducing such functions? To whom should I post it? (I've
>> included it in this posting for discussion) Where does the
>> documentation go?

I also work on an extension wrapping OpenSSL's CRL generation and OCSP
parsing/generation functions and wonder whether it makes sense to have
two or more extensions wrapping OpenSSL functionality or whether there is
public interest in having these functions in the stock distribution?

Moritz Bechler