easter_date() II

php.internals

Oliver Block

19 years ago
Hello, easter_date() returns a timestamp produced by C's mktime(). (ext/calendar/easter.c:111): Z_LVAL_P(return_value) = mktime(&te); AFAIK mktime() (time.h) is different to php's mktime() as it does not consider php's timezones, i,e, C's mktime does always return a timestamp of the local timezone. At least I conclude that from own tests. PHP's date functions on the other hand interpret the timestamp with respect to the php (default?) timezone. This leads to the wrong test results of easter_date.phpt as described in my posting from 22. Jan. Regards, Oliver

Pierre Joye

19 years ago
Hi Oliver, Report a bug using bugs.php.net (with a link to the patch diff -up :) This way it will not get lost in the internals archive. On 1/22/07, Oliver Block <lists@block-online.eu> wrote:

Oliver Block

19 years ago
Hello Pierre, a bug report will be no problem.:) Regarding a patch: timezone information needs to be accessible from within ext/calendar/easter.c if I got it right. The easiest way is to call php_mktime/PHP_FUNCTION(mktime) from within easter_date() - but is that possible/allowed/welcome? Regards, Oliver Am Montag, 22. Januar 2007 20:34 schrieb Pierre:
> Hi Oliver, > > Report a bug using bugs.php.net (with a link to the patch diff -up :) > > This way it will not get lost in the internals archive. > > On 1/22/07, Oliver Block <lists@block-online.eu> wrote: > > Hello, > > > > easter_date() returns a timestamp produced by C's mktime(). > > (ext/calendar/easter.c:111): > > > > Z_LVAL_P(return_value) = mktime(&te); > > > > AFAIK mktime() (time.h) is different to php's mktime() as it does not > > consider php's timezones, i,e, C's mktime does always return a timestamp > > of the local timezone. At least I conclude that from own tests. > > PHP's date functions on the other hand interpret the timestamp with > > respect to the php (default?) timezone. > > > > This leads to the wrong test results of easter_date.phpt as described in > > my posting from 22. Jan. > > > > Regards, > > > > Oliver > > > > -- > > PHP Internals - PHP Runtime Development Mailing List > > To unsubscribe, visit: http://www.php.net/unsub.php
-- Leben ist mehr als ... <http://www.nak-nrw.de/index.php?id=71>

Pierre Joye

19 years ago
On 1/23/07, Oliver Block <lists@block-online.eu> wrote:
> Hello Pierre, > > a bug report will be no problem.:) > > Regarding a patch: timezone information needs to be accessible from within > ext/calendar/easter.c if I got it right. The easiest way is to call > php_mktime/PHP_FUNCTION(mktime) from within easter_date() - but is that > possible/allowed/welcome?
No idea, report a bug and the maintainer will tell you his opinion :) --Pierre