On 02/04/07, Richard Quadling <rquadling@googlemail.com> wrote:
> On 22/03/07, Richard Quadling <rquadling@googlemail.com> wrote:
> > As subject.
> >
> Does anyone care about this? For those on Windows, the black box is
> REALLY annoying when you develop scheduled CLI scripts which call
> external apps. It takes focus away from what ever you are doing and
> there is no need for the window.
>
> I'm not saying that the shell shouldn't be launched, that is a
> separate issue, just that the console window shouldn't/needn't be
> shown.
>
> Regards,
>
> Richard Quadling.
>
>
> --
> -----
> Richard Quadling
> Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
> "Standing on the shoulders of some very clever giants!"
>
Just in case you can't see the patches ...
Index: tsrm_win32.c
===================================================================
RCS file: /repository/TSRM/tsrm_win32.c,v
retrieving revision 1.31
diff -u -r1.31 tsrm_win32.c
--- tsrm_win32.c 20 Mar 2007 17:57:44 -0000 1.31
+++ tsrm_win32.c 22 Mar 2007 15:39:50 -0000
@@ -219,7 +219,7 @@
cmd = (char*)malloc(strlen(command)+strlen(TWG(comspec))+sizeof(" /c "));
sprintf(cmd, "%s /c %s", TWG(comspec), command);
- if (!CreateProcess(NULL, cmd, &security, &security,
security.bInheritHandle, NORMAL_PRIORITY_CLASS, env, cwd, &startup,
&process)) {
+ if (!CreateProcess(NULL, cmd, &security, &security,
security.bInheritHandle, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW,
env, cwd, &startup, &process)) {
return NULL;
}
free(cmd);
Index: proc_open.c
===================================================================
RCS file: /repository/php-src/ext/standard/proc_open.c,v
retrieving revision 1.54
diff -u -r1.54 proc_open.c
--- proc_open.c 24 Feb 2007 16:25:55 -0000 1.54
+++ proc_open.c 22 Mar 2007 15:39:17 -0000
@@ -738,11 +738,11 @@
}
if (bypass_shell) {
- newprocok = CreateProcess(NULL, command, &security, &security,
TRUE, NORMAL_PRIORITY_CLASS, env.envp, cwd, &si, &pi);
+ newprocok = CreateProcess(NULL, command, &security, &security,
TRUE, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW, env.envp, cwd, &si,
&pi);
} else {
spprintf(&command_with_cmd, 0, "%s /c %s", GetVersion() <
0x80000000 ? COMSPEC_NT : COMSPEC_9X, command);
- newprocok = CreateProcess(NULL, command_with_cmd, &security,
&security, TRUE, NORMAL_PRIORITY_CLASS, env.envp, cwd, &si, &pi);
+ newprocok = CreateProcess(NULL, command_with_cmd, &security,
&security, TRUE, NORMAL_PRIORITY_CLASS | CREATE_NO_WINDOW, env.envp,
cwd, &si, &pi);
efree(command_with_cmd);
}
http://rquadling.php1h.com/proc_open.diff.txt
and
http://rquadling.php1h.com/tsrm_win32.diff.txt
--
-----
Richard Quadling
Zend Certified Engineer : http://zend.com/zce.php?c=ZEND002498&r=213474731
"Standing on the shoulders of some very clever giants!"
