Everything

php

removed stuff & fatals error in HEAD

php.internals

Antony Dovgal

19 years ago

Hello all.

I propose to change the error in HEAD that appears when enabling magic_quotes
and safe_mode from E_ERROR to E_WARNING.
It's not something that leaves the engine in unstable state, so I believe
E_ERROR is misused in this case.

It's also impossible to know even where exactly these INI options were declared
if they appeared in php.ini:

# php -i
PHP Fatal error:  Directive 'safe_mode' is no longer supported in PHP 6 and
greater in Unknown on line 0


I'll commit the patch in the evening if there are no (well-grounded) objections.

--
Wbr,
Antony Dovgal

Alexey Zakhlestin

19 years ago

I believe, that it will be better to make better error-messages regarding
place of options declarations. "safe_mode" and "magic_quotes" are things,
which some projects rely on heavily, so people should be forced to disable
these manually… It's kinda psychological effect: "we told you it won't work,
but you insisted"

On 3/23/07, Antony Dovgal <antony@zend.com> wrote:
>
> Hello all.
>
> I propose to change the error in HEAD that appears when enabling
> magic_quotes
> and safe_mode from E_ERROR to E_WARNING.
> It's not something that leaves the engine in unstable state, so I believe
> E_ERROR is misused in this case.
>
> It's also impossible to know even where exactly these INI options were
> declared
> if they appeared in php.ini:
>
>    # php -i
>    PHP Fatal error:  Directive 'safe_mode' is no longer supported in PHP 6
> and
>    greater in Unknown on line 0
>
>
> I'll commit the patch in the evening if there are no (well-grounded)
> objections.
>
> --
> Wbr,
> Antony Dovgal
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
Alexey Zakhlestin
http://blog.milkfarmsoft.com/

Antony Dovgal

19 years ago

On 03/23/2007 03:08 PM, Alexey Zakhlestin wrote:

> I believe, that it will be better to make better error-messages regarding
> place of options declarations.

Looks like you misunderstood the problem.
There is no script, so the error messages refer to "Unknown" file.

> "safe_mode" and "magic_quotes" are things,
> which some projects rely on heavily, so people should be forced to disable
> these manually… It's kinda psychological effect: "we told you it won't work,
> but you insisted"

--
Wbr,
Antony Dovgal

Alexey Zakhlestin

19 years ago

Isn't it possible to change this phrase to something like "in php's
configuration"?

On 3/23/07, Antony Dovgal <antony@zend.com> wrote:

>
> On 03/23/2007 03:08 PM, Alexey Zakhlestin wrote:
> > I believe, that it will be better to make better error-messages
> regarding
> > place of options declarations.
>
> Looks like you misunderstood the problem.
> There is no script, so the error messages refer to "Unknown" file.
>

--
Alexey Zakhlestin
http://blog.milkfarmsoft.com/

Antony Dovgal

19 years ago

On 03/23/2007 03:48 PM, Alexey Zakhlestin wrote:

> Isn't it possible to change this phrase to something like "in php's
> configuration"?

How would that help you?

--
Wbr,
Antony Dovgal

Johannes Schlueter

19 years ago

Hi,

I'd also like to completely remove get_magic_quotes_gpc() and similar
functions instead of having them resulting in a fatal error. The effect
would be the same - the script terminates - but function_exists() is
much nicer as check than version_compare().

Any objections?

johannes

On Fri, 2007-03-23 at 14:57 +0300, Antony Dovgal wrote:

Derick Rethans

19 years ago

On Fri, 23 Mar 2007, Johannes Schlüter wrote:

> Hi,
>
> I'd also like to completely remove get_magic_quotes_gpc() and similar
> functions instead of having them resulting in a fatal error. The effect
> would be the same - the script terminates - but function_exists() is
> much nicer as check than version_compare().
>
> Any objections?

No, remove the functions please. However, I think it's good to have an
error if somebody tries to set them in a configuration file still. But
we need a better error message saying in which config file they were
used.

regards,
Derick